You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In PR #255 we moved to allowing bf(mu ~ 1) to be the default for the formula option of epidist().
This means that users now do not need to specify a model on the distributional parameters of the model (aside from mu) if they don't want to.
Although this is nice, it does now mean that:
We must be specifying priors on both the Intercept_dpar and dpar parameters in epidist_family_prior()
If we have any post-processing which relies on knowing model names (e.g. Intercept_dpar) then it'll be more fiddly
An alternative proposal is to set dpar ~ 1 for any dpar left without a model. This would fix the two problems above but introduce its own problems:
Users may be confused that we've changed their model in the output
If a user puts a prior on dpar as an override then it won't easily work with the new Intercept_dpar parameter. Further: perhaps it's good to allow users to be putting priors on the distributional parameter itself, rather than the intercept
For the time being I'm happy to stick with things as they are, but if the downsides become more painful for some reason I could be convinced to switch approaches.
The text was updated successfully, but these errors were encountered:
* Scope notes on forcing a ~ 1 when noting provided
* Update globals.R
* Run document()
* The structure for the .make_intercepts_explicit helper function insertion
* Set-up test and documentation for helper function
* Return formula in placeholder
* First draft of "add ~ 1" functionality
* Trying to test by comparison to explicitly created formula
* Missing bracket
* Don't change the formula for parameters set to be a constant
* Simplify prior structure
* Set environments to NULL such that formulas are equal
* Fix to bug in prior checking test
* Scope notes on forcing a ~ 1 when noting provided
* Update globals.R
* Run document()
* The structure for the .make_intercepts_explicit helper function insertion
* Set-up test and documentation for helper function
* Return formula in placeholder
* First draft of "add ~ 1" functionality
* Trying to test by comparison to explicitly created formula
* Missing bracket
* Don't change the formula for parameters set to be a constant
* Simplify prior structure
* Set environments to NULL such that formulas are equal
* Fix to bug in prior checking test
Former-commit-id: 75f35476372837afd57b961d2deff077ddf18bc4 [formerly 41c3ea535f40cbdb271dcc98f8ed34dfbe059943]
Former-commit-id: 24c26025b125ab109cdad08095fe10d61db9264a
In PR #255 we moved to allowing
bf(mu ~ 1)
to be the default for theformula
option ofepidist()
.This means that users now do not need to specify a model on the distributional parameters of the model (aside from
mu
) if they don't want to.Although this is nice, it does now mean that:
Intercept_dpar
anddpar
parameters inepidist_family_prior()
Intercept_dpar
) then it'll be more fiddlyAn alternative proposal is to set
dpar ~ 1
for anydpar
left without a model. This would fix the two problems above but introduce its own problems:dpar
as an override then it won't easily work with the newIntercept_dpar
parameter. Further: perhaps it's good to allow users to be putting priors on the distributional parameter itself, rather than the interceptFor the time being I'm happy to stick with things as they are, but if the downsides become more painful for some reason I could be convinced to switch approaches.
The text was updated successfully, but these errors were encountered: