Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 235: Constant distributional parameters bug fix #255

Merged
merged 9 commits into from
Aug 29, 2024
Merged

Issue 235: Constant distributional parameters bug fix #255

merged 9 commits into from
Aug 29, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Aug 26, 2024 •
edited
Loading

Description

This PR closes #235. It:

  • Puts the default formuala = bf(mu ~ 1) i.e. removing sigma ~ 1
  • Changes the Stan code to include either real or vector in front of the distributional parameters depending on whether there is a model for them. For mu is always assumes there is a model. I think this might be a requirement of brms, but I'm not sure
  • Adds a prior on the sigma > 0 as the equivalent lognormal to the normal which is then exponentiated if it's an intercept only model
  • Doesn't add a test for bf(mu ~ 1) working because lots of the tests already have no explicit formula hence will be using this default

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes marked this pull request as ready for review August 27, 2024 08:55
@athowes athowes requested a review from seabbs August 27, 2024 08:55
seabbs
seabbs previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this looks good to me! Nice.

@seabbs seabbs enabled auto-merge (squash) August 29, 2024 10:17
@athowes athowes mentioned this pull request Aug 29, 2024
Closed
@athowes athowes requested a review from seabbs August 29, 2024 15:49
@seabbs seabbs disabled auto-merge August 29, 2024 15:52
@seabbs seabbs enabled auto-merge (squash) August 29, 2024 15:52
@seabbs seabbs merged commit 993f1ec into main Aug 29, 2024
7 checks passed
@seabbs seabbs deleted the vector-real branch August 29, 2024 16:59
This was referenced Aug 29, 2024
Closed
Closed
seabbs added a commit that referenced this pull request Jan 10, 2025
@athowes @seabbs
Issue 235: Constant distributional parameters bug fix (#255)
13ef2ea 
* Start by reproducing bug

* Use sigma prior

* Now passing with bf(mu ~ 1) and no model on sigma

* Change default to no model on sigma, run document

* Prior on sigma

* Add lb and ub

* Rebase conflict

* Missing bracket correction

---------

Co-authored-by: Sam Abbott <[email protected]>
Former-commit-id: e83add7ebf5f577696dc9b6d04faacd411faa202 [formerly 0fa2dc8206581186c1fb528e7bb606401b28d9b2]
Former-commit-id: 973e783b75044400561ccd5395e6eb6043789f3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs Awaiting requested review from seabbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vector or real meta bug
2 participants
@athowes @seabbs