-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalise handling priors for parameters set to constant #306
Labels
high
Required for next release
Comments
9 tasks
Possible solution:
Downside: maybe it's harder for us to be debugging if any replacements are going wrong. |
just have an optional arg that you set when its time to replace user priors I think |
9 tasks
As a part of this issue, we might like to also alter the structure of our priors so that |
9 tasks
9 tasks
seabbs
pushed a commit
that referenced
this issue
Oct 15, 2024
…erwriting (#379) * Add abort/warn option to .replace_prior then use it in epidist_prior, and delete NULL case in code * Fix bug (forgot to update name) * Update tests * Use code linking in epidist() * Add argument documentation * Redocument * Add testing that the parameter set to a constant is indeed a constant * Switch to "do nothing, or warn" prior set-up * Better warning message and bug fix * Expect a warning not an error * Alter args of .replace_prior to make more external sense * Keep old_prior as first argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#282 (comment) (and comment thread):
One plan here:
replace_prior
to do a warning rather than error when there is no prior to replaceepidist_prior
and remove the lower level parts about removing priors on constantsThe flaws in this plan:
replace_prior
to just do a warning then we don't need the utility function to remove priors on constant parameters sincedefault_prior
already won't have put a prior on a constant in there, so there will be nothing to replace, hence we just end up with a warningThe text was updated successfully, but these errors were encountered: