Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change full-screen visualisation shortcut to shift-space #6663

Merged
merged 4 commits into from
May 17, 2023

Conversation

Procrat
Copy link
Contributor

@Procrat Procrat commented May 12, 2023

Pull Request Description

Fixes #6260: The shortcut to open the full-screen visualisation is now shift-space so it doesn't interfere with the space shortcut to toggle the mini-visualisation.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the Scala, Java, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Procrat Procrat force-pushed the wip/procrat/shift-space-for-fullscreen-viz-6260 branch from e01c449 to fae1b87 Compare May 12, 2023 13:54
@Procrat Procrat marked this pull request as ready for review May 12, 2023 13:55
app/gui/view/graph-editor/src/lib.rs Outdated Show resolved Hide resolved
app/gui/view/graph-editor/src/lib.rs Show resolved Hide resolved
app/gui/view/graph-editor/src/lib.rs Show resolved Hide resolved
app/gui/view/graph-editor/src/shortcuts.rs Outdated Show resolved Hide resolved
Procrat added 3 commits May 15, 2023 09:46
…z-6260

* develop:
  Build nightlies every day. (#6681)
  Force `newDashboard` default on the CI-built packages. (#6680)
  Verify ascribed types of parameters really exist (#6584)
  SuggestionBuilder needs to send ascribedType of constructor parameters (#6655)
  Improvements to the Table visualization. (#6653)
  Removing flush (#6670)
  Improving widgets for take/drop (#6641)
…z-6260

* develop:
  Add verbose logs mention to CONTRIBUTING.md (#6703)
  Hide "shared with" column on local backend (#6684)
  Fix top bar styles (#6695)
  Fix opening cloud projects (#6683)
  Show spinner when opening/creating a project (#6321)
  Fix logic for enabling dashboard (#6696)
  Create unique atom getter suggestions (#6694)
  Ensure slow shutdown of LS always kicks off hooks (#6665)
  Fix `--startup.project` to bypass opening dashboard (#6671)
@farmaazon
Copy link
Contributor

farmaazon commented May 16, 2023

QA Report: 🔴

I was unable to close the visualization with escape. It wasn't technically requested by the issue (only in the review), but I think it will be a great UX enhancement (otherwise user could have no clue how to exit FS visualization).

@enso-bot
Copy link

enso-bot bot commented May 16, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-05-16):

Progress: address reviews; fixes for other PRs; address various other issues It should be finished by 2023-05-19.

@Procrat
Copy link
Contributor Author

Procrat commented May 17, 2023

I was unable to close the visualization with escape. It wasn't technically requested by the issue (only in the review), but I think it will be a great UX enhancement (otherwise user could have no clue how to exit FS visualization).

@farmaazon: I just tried it out again and it seems to work fine for me. What OS are you using? Do any of other escape shortcuts in the app work for you, e.g. exiting from editing text?

@farmaazon
Copy link
Contributor

Huh, after pulling changes (merge?) I'm also able to hide visualization with escape, so

QA 🍏

@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label May 17, 2023
@mergify mergify bot merged commit 102ce7a into develop May 17, 2023
@mergify mergify bot deleted the wip/procrat/shift-space-for-fullscreen-viz-6260 branch May 17, 2023 09:07
@somebody1234
Copy link
Contributor

whoops, wrong PR number

Procrat added a commit that referenced this pull request May 22, 2023
…t-rename

* develop:
  Widgets, Vector as Column, Viz Fixes and Rename Columns (#6768)
  Implement simple variants of `parse` for the Database backend (#6731)
  Enable `require-jsdoc` lint and add two lints related to React (#6403)
  Decimal/Integer .round and .int #6654 (#6743)
  Set suggestion reexports when serializing the library (#6778)
  Fix file uploading node expression. (#6689)
  Using WarningsLibrary to query for warnings (#6751)
  Implement `cast` for Table and Column (#6711)
  Display Initializing project... message when initializing project (#6661)
  Only send suggestions updates when type changes (#6755)
  sbt runEngineDistribution --debug to ease debuggging (#6745)
  Display "modified at" column on the cloud dashboard (#6687)
  Meta.meta Integer . methods (#6740)
  Show spinner while loading directory (#6714)
  Add cloud dashboard to changelog (#6688)
  Fix list editor panics during insertion (#6540)
  Update bug-report.yml
  Remove project create form (#6710)
  Change full-screen visualisation shortcut to shift-space (#6663)
Procrat added a commit that referenced this pull request May 22, 2023
* develop: (30 commits)
  Widgets, Vector as Column, Viz Fixes and Rename Columns (#6768)
  Implement simple variants of `parse` for the Database backend (#6731)
  Enable `require-jsdoc` lint and add two lints related to React (#6403)
  Decimal/Integer .round and .int #6654 (#6743)
  Set suggestion reexports when serializing the library (#6778)
  Fix file uploading node expression. (#6689)
  Using WarningsLibrary to query for warnings (#6751)
  Implement `cast` for Table and Column (#6711)
  Display Initializing project... message when initializing project (#6661)
  Only send suggestions updates when type changes (#6755)
  sbt runEngineDistribution --debug to ease debuggging (#6745)
  Display "modified at" column on the cloud dashboard (#6687)
  Meta.meta Integer . methods (#6740)
  Show spinner while loading directory (#6714)
  Add cloud dashboard to changelog (#6688)
  Fix list editor panics during insertion (#6540)
  Update bug-report.yml
  Remove project create form (#6710)
  Change full-screen visualisation shortcut to shift-space (#6663)
  Revert "Show spinner when opening/creating a project (#6321)" (#6712)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing double space to open full screen vis is closing it first
4 participants