Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --startup.project to bypass opening dashboard #6671

Merged
merged 1 commit into from
May 15, 2023

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

Fixes #6666

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234
Copy link
Contributor Author

@farmaazon you might want to test this to see whether it fixes the problem

@somebody1234 somebody1234 added the CI: No changelog needed Do not require a changelog entry for this PR. label May 12, 2023
@somebody1234
Copy link
Contributor Author

this PR is intentionally based on an old develop, to make it easier to reproduce the problem. there should be no merge conflicts.

@farmaazon
Copy link
Contributor

@farmaazon you might want to test this to see whether it fixes the problem

The issue is fixed 🎉

@PabloBuchu
Copy link
Contributor

qa 🟢

@PabloBuchu PabloBuchu merged commit 8569ab9 into develop May 15, 2023
@PabloBuchu PabloBuchu deleted the wip/sb/fix-startup-project branch May 15, 2023 11:47
@wdanilo
Copy link
Member

wdanilo commented May 16, 2023

Does it allow to go back to the dashboard? This option should be just a shorthand for opening a project, but everything should work just in a normal way, so going back to dashboard should be possible.

@somebody1234
Copy link
Contributor Author

@wdanilo i decided not to do that because it was much simpler this way - but i can open a new PR to add the correct behavior soon

@wdanilo
Copy link
Member

wdanilo commented May 16, 2023

There are 2 problems with the current solution:

  1. We can't tell users "hey, run Enso with this flag and see this project", as it will not work as normal Enso does.
  2. This introduces yet another mode of running Enso - this time, without dashboard. This means, that yet another mode needs to be checked during every Q/A, maintained, etc. This adds a lot of trouble.

So, yes, I think we should implement it in such a way, that it will not cause these 2 points above. We can do it in a separate PR ofc :)

Procrat added a commit that referenced this pull request May 16, 2023
…z-6260

* develop:
  Add verbose logs mention to CONTRIBUTING.md (#6703)
  Hide "shared with" column on local backend (#6684)
  Fix top bar styles (#6695)
  Fix opening cloud projects (#6683)
  Show spinner when opening/creating a project (#6321)
  Fix logic for enabling dashboard (#6696)
  Create unique atom getter suggestions (#6694)
  Ensure slow shutdown of LS always kicks off hooks (#6665)
  Fix `--startup.project` to bypass opening dashboard (#6671)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--startup.project option does not work with the new dashboard.
4 participants