-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --startup.project
to bypass opening dashboard
#6671
Conversation
@farmaazon you might want to test this to see whether it fixes the problem |
this PR is intentionally based on an old develop, to make it easier to reproduce the problem. there should be no merge conflicts. |
The issue is fixed 🎉 |
qa 🟢 |
Does it allow to go back to the dashboard? This option should be just a shorthand for opening a project, but everything should work just in a normal way, so going back to dashboard should be possible. |
@wdanilo i decided not to do that because it was much simpler this way - but i can open a new PR to add the correct behavior soon |
There are 2 problems with the current solution:
So, yes, I think we should implement it in such a way, that it will not cause these 2 points above. We can do it in a separate PR ofc :) |
…z-6260 * develop: Add verbose logs mention to CONTRIBUTING.md (#6703) Hide "shared with" column on local backend (#6684) Fix top bar styles (#6695) Fix opening cloud projects (#6683) Show spinner when opening/creating a project (#6321) Fix logic for enabling dashboard (#6696) Create unique atom getter suggestions (#6694) Ensure slow shutdown of LS always kicks off hooks (#6665) Fix `--startup.project` to bypass opening dashboard (#6671)
Pull Request Description
Fixes #6666
Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.