Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drop down for Locale like Encoding #6654

Merged
merged 15 commits into from
May 31, 2023
Merged

Add drop down for Locale like Encoding #6654

merged 15 commits into from
May 31, 2023

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented May 11, 2023 •
edited
Loading

Pull Request Description

Add dropdowns for locale parameters for format and parse methods.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@unfurl-links unfurl-links bot mentioned this pull request May 16, 2023
Closed
@GregoryTravis GregoryTravis requested a review from jdunkerley May 18, 2023 15:35
@GregoryTravis GregoryTravis requested a review from radeusgd May 18, 2023 18:46
@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label May 18, 2023
@GregoryTravis GregoryTravis requested a review from radeusgd May 19, 2023 13:40
mergify bot pushed a commit that referenced this pull request May 19, 2023
@GregoryTravis
Decimal/Integer .round and .int #6654 (#6743)
4f71673
Procrat added a commit that referenced this pull request May 22, 2023
@Procrat
Merge branch 'develop' into wip/procrat/fix-func-generation-on-projec…
0e9da81 
…t-rename

* develop:
  Widgets, Vector as Column, Viz Fixes and Rename Columns (#6768)
  Implement simple variants of `parse` for the Database backend (#6731)
  Enable `require-jsdoc` lint and add two lints related to React (#6403)
  Decimal/Integer .round and .int #6654 (#6743)
  Set suggestion reexports when serializing the library (#6778)
  Fix file uploading node expression. (#6689)
  Using WarningsLibrary to query for warnings (#6751)
  Implement `cast` for Table and Column (#6711)
  Display Initializing project... message when initializing project (#6661)
  Only send suggestions updates when type changes (#6755)
  sbt runEngineDistribution --debug to ease debuggging (#6745)
  Display "modified at" column on the cloud dashboard (#6687)
  Meta.meta Integer . methods (#6740)
  Show spinner while loading directory (#6714)
  Add cloud dashboard to changelog (#6688)
  Fix list editor panics during insertion (#6540)
  Update bug-report.yml
  Remove project create form (#6710)
  Change full-screen visualisation shortcut to shift-space (#6663)
Procrat added a commit that referenced this pull request May 22, 2023
@Procrat
Merge branch 'develop' into wip/procrat/home-button-6399
46418f1 
* develop: (30 commits)
  Widgets, Vector as Column, Viz Fixes and Rename Columns (#6768)
  Implement simple variants of `parse` for the Database backend (#6731)
  Enable `require-jsdoc` lint and add two lints related to React (#6403)
  Decimal/Integer .round and .int #6654 (#6743)
  Set suggestion reexports when serializing the library (#6778)
  Fix file uploading node expression. (#6689)
  Using WarningsLibrary to query for warnings (#6751)
  Implement `cast` for Table and Column (#6711)
  Display Initializing project... message when initializing project (#6661)
  Only send suggestions updates when type changes (#6755)
  sbt runEngineDistribution --debug to ease debuggging (#6745)
  Display "modified at" column on the cloud dashboard (#6687)
  Meta.meta Integer . methods (#6740)
  Show spinner while loading directory (#6714)
  Add cloud dashboard to changelog (#6688)
  Fix list editor panics during insertion (#6540)
  Update bug-report.yml
  Remove project create form (#6710)
  Change full-screen visualisation shortcut to shift-space (#6663)
  Revert "Show spinner when opening/creating a project (#6321)" (#6712)
  ...
@GregoryTravis GregoryTravis requested a review from jdunkerley May 25, 2023 15:47
@GregoryTravis GregoryTravis marked this pull request as ready for review May 25, 2023 19:14
jdunkerley
jdunkerley approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny tweak

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Locale.enso Outdated Show resolved Hide resolved
jdunkerley
jdunkerley approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny tweak

@GregoryTravis GregoryTravis requested a review from jdunkerley May 30, 2023 18:04
@radeusgd
Copy link
Member

Can we get a screenshot of the dropdown in the IDE?

I think for PRs where dropdowns are affected we should include screenshots to illustrate the changes.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label May 31, 2023
@mergify mergify bot merged commit 7e53cd9 into develop May 31, 2023
@mergify mergify bot deleted the wip/gmt/6410-locale-dropdown branch May 31, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GregoryTravis @radeusgd @jdunkerley