Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuggestionBuilder needs to send ascribedType of constructor parameters #6611

Closed
jdunkerley opened this issue May 9, 2023 · 8 comments · Fixed by #6655
Closed

SuggestionBuilder needs to send ascribedType of constructor parameters #6611

jdunkerley opened this issue May 9, 2023 · 8 comments · Fixed by #6655
Assignees
Labels
-language-server p-highest Should be completed ASAP x-new-feature Type: new feature request

Comments

@jdunkerley
Copy link
Member

When building the meta data for a constructor (buildAtomConstructor in SuggestionBuilder), the ascribed type of the parameters is not used and only Any is passed.

In order for the dropdowns to work this must contain the type information.

@jdunkerley jdunkerley added p-highest Should be completed ASAP x-new-feature Type: new feature request -language-server labels May 9, 2023
@jdunkerley jdunkerley added this to the Design Partners milestone May 9, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board May 9, 2023
@JaroslavTulach
Copy link
Member

Slightly related to #6584 which is supposed to verify that ascribedTypes are correct.

@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board May 9, 2023
@enso-bot
Copy link

enso-bot bot commented May 11, 2023

Dmitry Bushev reports a new STANDUP for yesterday (2023-05-10):

Progress: Started working on the task. Implemented a test reproducing the issue. Found that the ascribed type field is set for the atom constructor argument. Discovered that there is no type metadata assigned to the constructor. Started investigation It should be finished by 2023-05-15.

Next Day: Next day I will be working on the #6611 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented May 11, 2023

Dmitry Bushev reports a new STANDUP for today (2023-05-11):

Progress: Continue working on the task. Found that the IR misses the metadata on the ascribed type. Started investigating. Fixed attaching metadata in the TypeSignatures compiler pass. Fixed resolving type names of the ascribed type in the TypeNames compiler pass. Was able to make the test case work It should be finished by 2023-05-15.

Next Day: Next day I will be working on the #6611 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented May 12, 2023

Dmitry Bushev reports a new STANDUP for today (2023-05-12):

Progress: Continue working on the task. Fixed the AliasAnalysis compiler test. Fixed building the return parameter for atom constructor argument functions. Created a PR It should be finished by 2023-05-15.

Next Day: Next day I will be working on the #6611 task. Continue working on the task

@mergify mergify bot closed this as completed in #6655 May 13, 2023
mergify bot pushed a commit that referenced this issue May 13, 2023
#6655)

close #6611

Changelog:
- update: run compiler passes on the `ascribedType` field of the constructor arguments
- update: suggestion builder uses the type information attached to `ascribedType`
- feat: resolve qualified names in type signatures
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board May 13, 2023
@enso-bot
Copy link

enso-bot bot commented May 14, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-05-13):

Progress: - looking at Dmitry's ascribed types: #6655 (comment)
- bugfix for Dmitry's PR: #6655 (comment) It should be finished by 2023-05-15.

Next Day: Adjust #6584 to Dmitry's #6655

@enso-bot
Copy link

enso-bot bot commented May 15, 2023

Jaroslav Tulach reports a new STANDUP for the last Saturday (2023-05-13):

Progress: - Adjusting #6584 to #6655
- Merged in! It should be finished by 2023-05-15.

Next Day: EurOpen conference & bugfixing

mergify bot pushed a commit that referenced this issue May 15, 2023
related #6611

Prevent creating atom getters with the same name.
@enso-bot
Copy link

enso-bot bot commented May 15, 2023

Dmitry Bushev reports a new STANDUP for today (2023-05-15):

Progress: Finishing working on the task. PR introduced a regression with the suggestions database. Debugged and fixed it. Added a failover logic to identify such cases more easily in the future. It should be finished by 2023-05-15.

Next Day: Next day I will be working on the #6611 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented May 16, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-05-15):

Progress: - bookclub attempt: https://discord.com/channels/401396655599124480/1106533940086448258/1107519802995654666
- QA for: #6694 (review)
- preparing & reporting "type errors as early as possible": #6682
- preparing presentation about enso
- standups, meetings, demos: https://github.com/orgs/enso-org/discussions/6697
- analyzing #6630
- Discussing Meta.type_of Nothing It should be finished by 2023-05-15.

Next Day: Presentation at EurOpen conference & planning

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
GitHub

mergify bot pushed a commit that referenced this issue May 23, 2023
related #6611

Changelog:
- update: set tag values for arguments with ascribed types

# Important Notes
![2023-05-23-002112_697x311_scrot](https://github.com/enso-org/enso/assets/357683/10d1c03b-45b7-4133-b4aa-80d1f1ea8e84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-language-server p-highest Should be completed ASAP x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants