-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuggestionBuilder needs to send ascribedType
of constructor parameters
#6611
Comments
Slightly related to #6584 which is supposed to verify that |
Dmitry Bushev reports a new STANDUP for yesterday (2023-05-10): Progress: Started working on the task. Implemented a test reproducing the issue. Found that the ascribed type field is set for the atom constructor argument. Discovered that there is no type metadata assigned to the constructor. Started investigation It should be finished by 2023-05-15. Next Day: Next day I will be working on the #6611 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for today (2023-05-11): Progress: Continue working on the task. Found that the IR misses the metadata on the ascribed type. Started investigating. Fixed attaching metadata in the TypeSignatures compiler pass. Fixed resolving type names of the ascribed type in the TypeNames compiler pass. Was able to make the test case work It should be finished by 2023-05-15. Next Day: Next day I will be working on the #6611 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for today (2023-05-12): Progress: Continue working on the task. Fixed the AliasAnalysis compiler test. Fixed building the return parameter for atom constructor argument functions. Created a PR It should be finished by 2023-05-15. Next Day: Next day I will be working on the #6611 task. Continue working on the task |
Jaroslav Tulach reports a new STANDUP for yesterday (2023-05-13): Progress: - looking at Dmitry's ascribed types: #6655 (comment) |
related #6611 Prevent creating atom getters with the same name.
Dmitry Bushev reports a new STANDUP for today (2023-05-15): Progress: Finishing working on the task. PR introduced a regression with the suggestions database. Debugged and fixed it. Added a failover logic to identify such cases more easily in the future. It should be finished by 2023-05-15. Next Day: Next day I will be working on the #6611 task. Continue working on the task |
Jaroslav Tulach reports a new STANDUP for yesterday (2023-05-15): Progress: - bookclub attempt: https://discord.com/channels/401396655599124480/1106533940086448258/1107519802995654666 Next Day: Presentation at EurOpen conference & planning
|
related #6611 Changelog: - update: set tag values for arguments with ascribed types # Important Notes ![2023-05-23-002112_697x311_scrot](https://github.com/enso-org/enso/assets/357683/10d1c03b-45b7-4133-b4aa-80d1f1ea8e84)
When building the meta data for a constructor (
buildAtomConstructor
inSuggestionBuilder
), the ascribed type of the parameters is not used and onlyAny
is passed.In order for the dropdowns to work this must contain the type information.
The text was updated successfully, but these errors were encountered: