Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unique suggestions index #6692

Closed
wants to merge 2 commits into from
Closed

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented May 15, 2023

Pull Request Description

related #6611

It is checked by the compiler now. Fixes an issue when the language server fails to load the library suggestions.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label May 15, 2023
@4e6 4e6 self-assigned this May 15, 2023
@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label May 15, 2023
@JaroslavTulach
Copy link
Member

I've just tried buildEngineDistribution with your branch and the IDE seems to show component browser filled with reasonable elements. Please integrate.

@4e6 4e6 removed the CI: Ready to merge This PR is eligible for automatic merge label May 15, 2023
@4e6 4e6 closed this May 15, 2023
@4e6 4e6 deleted the wip/db/6611-fix-suggestions branch May 15, 2023 12:19
@4e6
Copy link
Contributor Author

4e6 commented May 15, 2023

Fixed by #6694

@JaroslavTulach
Copy link
Member

... component browser filled with reasonable elements...

Later I noticed that some things are missing. I don't see select_columns or rows on Table!?

Dmitry has investigated the problem meanwhile and created #6694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants