Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and implement rounding functions #5194

Closed
wdanilo opened this issue Feb 5, 2023 · 11 comments · Fixed by #6743
Closed

Design and implement rounding functions #5194

wdanilo opened this issue Feb 5, 2023 · 11 comments · Fixed by #6743
Assignees
Labels
-libs Libraries: New libraries to be implemented l-derived-columns p-low Low priority x-design x-new-feature Type: new feature request
Milestone

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by James Dunkerley.
Original issue is here.


Want to add a round function to numbers.
Should take a number of decimal places (0 by default).
Should also allow specify midpoint rounding method by and Atom type.

https://support.microsoft.com/en-us/office/round-function-c018c5d8-40fb-4053-90b1-b3e7f61a213c

Additionally, want to add floor, ceil and round to the column types.

  • The column type may not have control of the midpoint rounding.
@wdanilo wdanilo added this to the Beta Release milestone Feb 6, 2023
@jdunkerley jdunkerley moved this to ❓New in Issues Board Feb 7, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Feb 14, 2023
@GregoryTravis GregoryTravis moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 8, 2023
@enso-bot
Copy link

enso-bot bot commented May 9, 2023

Greg Travis reports a new STANDUP for today (2023-05-09):

Progress: Reviews; learning about 1-arg and 2-arg builtins; investigating overflow + Numbers_Spec It should be finished by 2023-05-15.

Next Day: more rounding cases

@enso-bot
Copy link

enso-bot bot commented May 10, 2023

Greg Travis reports a new STANDUP for today (2023-05-10):

Progress: Rounding precisoin, edge cases, struggling once again with bulitins, overloading, and default arguments It should be finished by 2023-05-15.

Next Day: more probably

@enso-bot
Copy link

enso-bot bot commented May 15, 2023

Greg Travis reports a new STANDUP for today (2023-05-15):

Progress: Integer rounding; Decimal.int; trying to get it to recognize my Truffle node; trying to get widgets to appear; Locale reflection It should be finished by 2023-05-15.

Next Day: same

@enso-bot
Copy link

enso-bot bot commented May 16, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-05-16):

Summary: There is 1 day delay in implementation of the Design and implement rounding functions (#5194) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: test failure; CI failure

@enso-bot
Copy link

enso-bot bot commented May 16, 2023

Greg Travis reports a new STANDUP for today (2023-05-16):

Progress: Getting my builtins detected; BigDecimal precision; large small integers It should be finished by 2023-05-16.

Next Day: same

@enso-bot
Copy link

enso-bot bot commented May 17, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-05-17):

Summary: There is 1 day delay in implementation of the Design and implement rounding functions (#5194) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: reverting to simple implementation, with pending tests for edge cases

@enso-bot
Copy link

enso-bot bot commented May 17, 2023

Greg Travis reports a new STANDUP for today (2023-05-17):

Progress: Simple implementation, PR It should be finished by 2023-05-17.

Next Day: review

@GregoryTravis GregoryTravis linked a pull request May 18, 2023 that will close this issue
5 tasks
@enso-bot
Copy link

enso-bot bot commented May 18, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-05-18):

Summary: There is 1 day delay in implementation of the Design and implement rounding functions (#5194) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: review

@enso-bot
Copy link

enso-bot bot commented May 18, 2023

Greg Travis reports a new STANDUP for today (2023-05-18):

Progress: round + locale reviews; trying to get widgets to appear It should be finished by 2023-05-18.

Next Day: same

@mergify mergify bot closed this as completed in #6743 May 19, 2023
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board May 19, 2023
@enso-bot
Copy link

enso-bot bot commented May 19, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-05-19):

Summary: There is 1 day delay in implementation of the Design and implement rounding functions (#5194) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: took too long with edge cases

@enso-bot
Copy link

enso-bot bot commented May 19, 2023

Greg Travis reports a new STANDUP for today (2023-05-19):

Progress: round + locale reviews; trying to get widgets to appear It should be finished by 2023-05-19.

Next Day: same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented l-derived-columns p-low Low priority x-design x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants