-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pressing double space to open full screen vis is closing it first #6260
Comments
This is rather old regression so there is no point in bisecting. |
Is it actually a regression? @sylwiabr Do you remember it working at any point? Because I think it always worked this way. We may check even the last alpha package. |
@wdanilo mentioned we were handling it specially to preserve such behavior. |
The double pressing is handled in the general EnsoGL keyboard handling system. I haven't found any code suppressing single press when double press is expected. Also, I don't know how to handle it properly. We usually do not want to delay GUI reactions for keystrokes - and this would be necessary if we want to suppress single press event when double pressed event is fired. So probably we need to handle this in visualization container. But here too, I think, delaying hiding visualization on single space press would give a bad UX. Perhaps we could restrain from deleting visualization instance for some time after hiding visualization (so the state like changed column width will be preserved). However, maybe we should somehow preserve visualization state not only in "switching to full screen" scenario? |
100% agree with Adam, this would be a bad UX. Hmm, @farmaazon @sylwiabr do you have proposals of how it might work? Let's consider ANY change, including changing shortcuts. |
I would suggest |
Let's do it :) |
Fixes #6260: The shortcut to open the full-screen visualisation is now `shift-space` so it doesn't interfere with the `space` shortcut to toggle the mini-visualisation.
Discord username
No response
What type of issue is this?
Transient – Occuring only once
Is this issue blocking you from using Enso?
Is this a regression?
What issue are you facing?
Having the visualization under the node open and pressing double space to have it full screen is closing it and then reopening. This causes the settings of the visualization (like custom columns width for table) to reset.
Expected behaviour
Opening the full screen visualization should not close it.
How we can reproduce it?
No response
Screenshots or screencasts
No response
Enso Version
2023.1.1-nightly.2023.4.13
Browser or standalone distribution
Standalone distribution
Browser Version or standalone distribution
standalone
Operating System
MacOS
Operating System Version
No response
Hardware you are using
No response
The text was updated successfully, but these errors were encountered: