Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust {Table|Column}.parse to use Value_Type #6213

Merged
merged 8 commits into from
Apr 6, 2023
Merged

Adjust {Table|Column}.parse to use Value_Type #6213

merged 8 commits into from
Apr 6, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Apr 5, 2023

Pull Request Description

Closes #5660

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 5, 2023
@radeusgd radeusgd self-assigned this Apr 5, 2023
@radeusgd radeusgd requested a review from jdunkerley as a code owner April 5, 2023 23:59
@radeusgd radeusgd changed the title s/parse_values/parse/g Adjust {Table|Column}.parse to use Value_Type Apr 6, 2023
@radeusgd radeusgd linked an issue Apr 6, 2023 that may be closed by this pull request
Adjust Table.parse_values and Column.parse to use the Value_Type type #5660
Closed
@radeusgd radeusgd requested a review from GregoryTravis April 6, 2023 08:01
@radeusgd radeusgd force-pushed the wip/radeusgd/align-parse-5660 branch from 5cf4629 to 2cc0be6 Compare April 6, 2023 08:16
jdunkerley
jdunkerley approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from wip/radeusgd/union-in-database-5235 to develop April 6, 2023 08:40
@radeusgd radeusgd force-pushed the wip/radeusgd/align-parse-5660 branch from 2cc0be6 to e99f574 Compare April 6, 2023 08:51
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Apr 6, 2023
@mergify mergify bot merged commit f5db35a into develop Apr 6, 2023
@mergify mergify bot deleted the wip/radeusgd/align-parse-5660 branch April 6, 2023 10:58
Procrat added a commit that referenced this pull request Apr 6, 2023
@Procrat
Merge branch 'develop' into wip/procrat/toggle-reevaluation-button-5929
92e0c57 
* develop:
  Project Sharing (#6077)
  Adjust `{Table|Column}.parse` to use `Value_Type` (#6213)
  Add cloud endpoints for frontend (#6002)
  Implement `Table.union` for Database backend (#6204)
  Batch insert suggestions (#6189)
  Formatter fix to not fail when encountering an invalid symlink. (#6172)
  Suspended atom fields are evaluated only once (#6151)
  Text.to_display_text is (shortened) identity (#6174)
  Engine benchmark visualization tool can compare two bench runs (#6198)
  Add PRIVATE so function hidden from Component Browser and other tidying... (#6207)
  Hotfix for #6203. (#6210)
MichaelMauderer pushed a commit that referenced this pull request Apr 25, 2023
@radeusgd @MichaelMauderer
Adjust {Table|Column}.parse to use Value_Type (#6213)
11049ff 
Closes #5660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

Assignees

@radeusgd radeusgd

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust Table.parse_values and Column.parse to use the Value_Type type
2 participants
@radeusgd @jdunkerley