Text.to_display_text is (shortened) identity #6174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
4e6 and
hubertp
as code owners
radeusgd
reviewed
Apr 3, 2023
...me/src/main/java/org/enso/interpreter/node/expression/builtin/text/AnyToDisplayTextNode.java
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Apr 3, 2023
2 tasks
radeusgd
approved these changes
Apr 4, 2023
4e6
approved these changes
Apr 5, 2023
JaroslavTulach
added
the
CI: Ready to merge
hubertp
approved these changes
Apr 5, 2023
| @@ -32,6 +35,22 @@ Text showExceptions( | |||
| } | |||
| } | |||
|
|
|||
| @Specialization | |||
| Text convertText(Text self) { | |||
| final var limit = 80; | |||
There was a problem hiding this comment.
shouldn't that be lifted to a (private static final) constant ?
There was a problem hiding this comment.
Originally the limit was only used locally in a single method. Then I had to move the iterator manipulation behind @TruffleBoundary...
jdunkerley
approved these changes
Apr 5, 2023
| if (self.length() < limit) { | ||
| return self; | ||
| } else { | ||
| return takePrefix(self, limit); |
There was a problem hiding this comment.
should we an ellipsis here … (U+2026)
There was a problem hiding this comment.
Sounds like a good idea indeed.
There was a problem hiding this comment.
should we an ellipsis here
"should we add an ellipsis?" is the question?
4 tasks
Procrat
added a commit
that referenced
this pull request
Apr 6, 2023
* develop: Project Sharing (#6077) Adjust `{Table|Column}.parse` to use `Value_Type` (#6213) Add cloud endpoints for frontend (#6002) Implement `Table.union` for Database backend (#6204) Batch insert suggestions (#6189) Formatter fix to not fail when encountering an invalid symlink. (#6172) Suspended atom fields are evaluated only once (#6151) Text.to_display_text is (shortened) identity (#6174) Engine benchmark visualization tool can compare two bench runs (#6198) Add PRIVATE so function hidden from Component Browser and other tidying... (#6207) Hotfix for #6203. (#6210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #5971.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,
style guides.