Implement Table.union for Database backend
#6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/radeusgd/union-in-database-5235
branch
from
ed1e5e7 to
9d882a3
Compare
GregoryTravis
approved these changes
Apr 5, 2023
jdunkerley
approved these changes
Apr 5, 2023
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Column.enso
Outdated
Show resolved
Hide resolved
| @@ -13,6 +13,7 @@ import Standard.Table.Data.Expression.Expression | |||
| import Standard.Table.Data.Expression.Expression_Error | |||
| import Standard.Table.Data.Join_Condition.Join_Condition | |||
| import Standard.Table.Data.Join_Kind.Join_Kind | |||
| import Standard.Table.Data.Match_Columns as Match_Columns_Helpers | |||
There was a problem hiding this comment.
Because we import Match_Columns type just a few lines above.
And we need to distinguish the type from the module.
I'd like to keep the helpers static on the module to keep them more hidden - if they are on the type they are easier to use by users which they are not intended for that.
cast expressions on union to unify types
TODO: bool->int
For now less efficient query metadata fetching, TODO probably worth to just infer SQLite types locally and override
…x for Postgres type name bool.
Proper solution needed (TODO add task to infer SQLite types locally)
radeusgd
force-pushed
the
wip/radeusgd/union-in-database-5235
branch
from
0adc787 to
d8307e4
Compare
Procrat
added a commit
that referenced
this pull request
Apr 6, 2023
* develop: Project Sharing (#6077) Adjust `{Table|Column}.parse` to use `Value_Type` (#6213) Add cloud endpoints for frontend (#6002) Implement `Table.union` for Database backend (#6204) Batch insert suggestions (#6189) Formatter fix to not fail when encountering an invalid symlink. (#6172) Suspended atom fields are evaluated only once (#6151) Text.to_display_text is (shortened) identity (#6174) Engine benchmark visualization tool can compare two bench runs (#6198) Add PRIVATE so function hidden from Component Browser and other tidying... (#6207) Hotfix for #6203. (#6210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #5235
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.