Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay creation of project root EnsoFile until it is really needed #6149

Merged
merged 21 commits into from
Apr 3, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Mar 30, 2023

Pull Request Description

Delay creation of EnsoFile until it is needed.

Important Notes

By putting breakpoint into Atom constructor I realized few EnsoProjectNode instances may be created when parsing the project. It makes no sense to also create EnsoFile for them - until it is needed.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests continue to work.

@JaroslavTulach JaroslavTulach added CI: No changelog needed Do not require a changelog entry for this PR. -compiler --low-performance labels Mar 30, 2023
@JaroslavTulach JaroslavTulach requested a review from kustosz March 30, 2023 14:07
@JaroslavTulach JaroslavTulach requested a review from 4e6 as a code owner March 30, 2023 14:07
@JaroslavTulach JaroslavTulach self-assigned this Mar 30, 2023
@JaroslavTulach JaroslavTulach requested a review from hubertp as a code owner March 30, 2023 14:07
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Mar 30, 2023
@JaroslavTulach JaroslavTulach added this to the Design Partners milestone Mar 30, 2023
Copy link
Member Author

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR is ready for integration. Please take a look @hubertp, @4e6.

@mergify mergify bot merged commit 310a2d8 into develop Apr 3, 2023
@mergify mergify bot deleted the wip/jtulach/DelayCreationOfProjectAtom branch April 3, 2023 14:03
@enso-bot
Copy link

enso-bot bot commented Apr 4, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-04-03):

Progress: - integrated enso_project: #6149

Next Day: Polish & integrate Any.== speedup

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--low-performance -compiler CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants