-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay creation of project root EnsoFile until it is really needed #6149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
CI: No changelog needed
Do not require a changelog entry for this PR.
-compiler
--low-performance
labels
Mar 30, 2023
JaroslavTulach
added
the
CI: Ready to merge
This PR is eligible for automatic merge
label
Mar 30, 2023
…g/enso into wip/jtulach/DelayCreationOfProjectAtom
JaroslavTulach
commented
Apr 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hubertp
approved these changes
Apr 3, 2023
Jaroslav Tulach reports a new STANDUP for yesterday (2023-04-03): Progress: - integrated enso_project: #6149
Next Day: Polish & integrate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
--low-performance
-compiler
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Delay creation of
EnsoFile
until it is needed.Important Notes
By putting breakpoint into
Atom
constructor I realized fewEnsoProjectNode
instances may be created when parsing the project. It makes no sense to also createEnsoFile
for them - until it is needed.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,
style guides. In case you are using a language not listed above, follow the Rust style guide.