Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Table.parse_values and Column.parse to use the Value_Type type #5660

Closed
jdunkerley opened this issue Feb 15, 2023 · 2 comments · Fixed by #6213
Closed

Adjust Table.parse_values and Column.parse to use the Value_Type type #5660

jdunkerley opened this issue Feb 15, 2023 · 2 comments · Fixed by #6213
Assignees
@radeusgd
Labels
-libs Libraries: New libraries to be implemented l-table-column-datatypes x-new-feature Type: new feature request
Milestone
Design Partners

Comments

@jdunkerley
Copy link
Member

Currently the type selection is based on the Enso type.

This argument should be replaced with a Value_Type argument.

It should also cause validation of limits for integer type for example.
@jdunkerley jdunkerley added -libs Libraries: New libraries to be implemented l-table-column-datatypes labels Feb 15, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone Feb 15, 2023
@jdunkerley jdunkerley added the x-new-feature Type: new feature request label Feb 15, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Feb 15, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to ❓New in Issues Board Feb 15, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Feb 15, 2023
This was referenced Mar 28, 2023
Closed
Closed
@radeusgd
Copy link
Member

Shall we rename Table.parse_values to Table.parse? The design seems to use parse for the name, but the current implementation is parse_values. @jdunkerley any opinions on this?

@radeusgd radeusgd moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 5, 2023
@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Apr 5, 2023
@radeusgd radeusgd mentioned this issue Apr 5, 2023
Merged
5 tasks
@radeusgd radeusgd linked a pull request Apr 6, 2023 that will close this issue
Adjust {Table|Column}.parse to use Value_Type #6213
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Apr 6, 2023

Radosław Waśko reports a new STANDUP for yesterday (2023-04-05):

Progress: Union is ready for merge. Implemented the parse_values adjustment and prepared the PR. It should be finished by 2023-04-06.

Next Day: Next day I will be working on the #5254 task. Get the PR merged, start work on the Full Join workaround.

@mergify mergify bot closed this as completed in #6213 Apr 6, 2023
mergify bot pushed a commit that referenced this issue Apr 6, 2023
@radeusgd
Adjust {Table|Column}.parse to use Value_Type (#6213)
f5db35a 
Closes #5660
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Apr 6, 2023
MichaelMauderer pushed a commit that referenced this issue Apr 25, 2023
@radeusgd @MichaelMauderer
Adjust {Table|Column}.parse to use Value_Type (#6213)
11049ff 
Closes #5660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radeusgd radeusgd

Labels
-libs Libraries: New libraries to be implemented l-table-column-datatypes x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
Design Partners
Development

Successfully merging a pull request may close this issue.

Adjust {Table|Column}.parse to use Value_Type enso-org/enso
2 participants
@radeusgd @jdunkerley