Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parse extensions to Text type. #6330

Closed
jdunkerley opened this issue Apr 18, 2023 · 2 comments · Fixed by #6404
Closed

Add parse extensions to Text type. #6330

jdunkerley opened this issue Apr 18, 2023 · 2 comments · Fixed by #6404
Assignees
@GregoryTravis
Labels
-libs Libraries: New libraries to be implemented
Milestone
Design Partners

Comments

@jdunkerley
Copy link
Member

Currently there are various "parse" methods on value types such as JSON, Date, Integer.

As the component browser favours methods over statics we should expose these as extensions.

For example:

Text.parse_json self -> Json =
Text.parse_url self -> Url =
Text.parse_number self -> Number =
Text.parse_integer self radix:Integer -> Integer =
Text.parse_date self format:Text|Nothing=Nothing -> Date = rename pattern to format

There are other parses to be included...
@jdunkerley jdunkerley added the -libs Libraries: New libraries to be implemented label Apr 18, 2023
@jdunkerley jdunkerley added this to the Design Partners milestone Apr 18, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Apr 18, 2023
@GregoryTravis GregoryTravis moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 24, 2023
@enso-bot
Copy link

enso-bot bot commented Apr 24, 2023

Greg Travis reports a new STANDUP for today (2023-04-24):

Progress: Ready for review It should be finished by 2023-04-25.

Next Day: 6329

@jdunkerley jdunkerley linked a pull request Apr 25, 2023 that will close this issue
Add parse extensions to Text type. #6330 #6404
Merged
5 tasks
@jdunkerley jdunkerley moved this from 🔧 Implementation to 👁️ Code review in Issues Board Apr 25, 2023
@enso-bot
Copy link

enso-bot bot commented Apr 25, 2023

Greg Travis reports a new STANDUP for today (2023-04-25):

Progress: Review It should be finished by 2023-04-25.

Next Day: Resume 6329

@mergify mergify bot closed this as completed in #6404 Apr 26, 2023
mergify bot pushed a commit that referenced this issue Apr 26, 2023
@GregoryTravis
Add parse extensions to Text type. #6330 (#6404)
255edda 
Add type-specific parse stubs to Text, e.g.:
Text.parse_json self -> Json =
Text.parse_url self -> Url =
Text.parse_number self -> Number =
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Apr 26, 2023
Akirathan pushed a commit that referenced this issue Apr 26, 2023
@GregoryTravis @Akirathan
Add parse extensions to Text type. #6330 (#6404)
4a2720b 
Add type-specific parse stubs to Text, e.g.:
Text.parse_json self -> Json =
Text.parse_url self -> Url =
Text.parse_number self -> Number =
Procrat added a commit that referenced this issue Apr 27, 2023
@Procrat
Merge branch 'develop' into wip/procrat/json-viz-last-row-6196
9452501 
* develop:
  Passing events to sub-widgets in List Editor and refactoring of the slider component. (#6433)
  Revert "Cloud/desktop mode switcher (#6308)" (#6444)
  Widgets integrated with graph nodes (#6347)
  Table Visualization and display text changes. (#6382)
  Skip redundant compilations (#6436)
  Add parse extensions to Text type. #6330 (#6404)
  Cloud/desktop mode switcher (#6308)
  Replace Table should_equal with should_equal_verbose (#6405)
  Rollback event handling changes for the mouse (#6396)
  Dashboard directory interactivity (#6279)
  Ability to change the execution environment between design and live. (#6341)
  Implementation of elements adding to List Editor and a lot of internal API (#6390)
  Drop method exported from WASM + removing leaks. (#6365)
  Turn null into UnexpectedExpression when Union type is incomplete (#6415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregoryTravis GregoryTravis

Labels
-libs Libraries: New libraries to be implemented
Projects
Issues Board
Archived in project
Milestone
Design Partners
Development

Successfully merging a pull request may close this issue.

Add parse extensions to Text type. #6330 enso-org/enso
2 participants
@jdunkerley @GregoryTravis