Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Table should_equal with should_equal_verbose #6405

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

GregoryTravis
Copy link
Contributor

Pull Request Description

Table.should_equal_verbose shows the contents of the tables on failure; let's make this the standard comparison.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 24, 2023
@GregoryTravis GregoryTravis marked this pull request as ready for review April 24, 2023 19:24
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I'm glad the test suite is improving.

Just one small suggestion that we could have an additional check.

test/Table_Tests/src/Util.enso Outdated Show resolved Hide resolved
@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Apr 25, 2023
@mergify mergify bot merged commit dcfbf84 into develop Apr 26, 2023
@mergify mergify bot deleted the wip/gmt/should_equal_verbose branch April 26, 2023 14:01
Akirathan pushed a commit that referenced this pull request Apr 26, 2023
Table.should_equal_verbose shows the contents of the tables on failure; let's make this the standard comparison.
Procrat added a commit that referenced this pull request Apr 27, 2023
* develop:
  Passing events to sub-widgets in List Editor and refactoring of the slider component. (#6433)
  Revert "Cloud/desktop mode switcher (#6308)" (#6444)
  Widgets integrated with graph nodes (#6347)
  Table Visualization and display text changes. (#6382)
  Skip redundant compilations (#6436)
  Add parse extensions to Text type. #6330 (#6404)
  Cloud/desktop mode switcher (#6308)
  Replace Table should_equal with should_equal_verbose (#6405)
  Rollback event handling changes for the mouse (#6396)
  Dashboard directory interactivity (#6279)
  Ability to change the execution environment between design and live. (#6341)
  Implementation of elements adding to List Editor and a lot of internal API (#6390)
  Drop method exported from WASM + removing leaks. (#6365)
  Turn null into UnexpectedExpression when Union type is incomplete (#6415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants