Passing events to sub-widgets in List Editor and refactoring of the slider component. #6433
Conversation
wdanilo
added
the
CI: No changelog needed
wdanilo
requested review from
MichaelMauderer,
farmaazon,
kazcw and
mwu-tow
as code owners
|
|
||
| insert((Index, Weak<T>)), | ||
| insert((Index, Rc<RefCell<Option<T>>>)), |
There was a problem hiding this comment.
Why this has no docstring while other two inputs do?
| @@ -362,7 +358,7 @@ impl<T: display::Object + CloneRef> ListEditor<T> { | |||
|
|
|||
| // Do not pass events to children, as we don't know whether we are about to drag | |||
| // them yet. | |||
| eval on_down ([] (event) event.stop_propagation()); | |||
|
|
|||
There was a problem hiding this comment.
Does the comment above remains up-to-date after the change?
|
|
||
| on_item_removed(Response<(Index, Weak<T>)>), | ||
| on_item_removed(Response<(Index, Rc<RefCell<Option<T>>>)>), |
There was a problem hiding this comment.
The same question as above.
| slider10.frp.orientation(Axis2::Y); | ||
| self.root.add_child(&slider10); | ||
| self.sliders.borrow_mut().push(slider10); | ||
| // |
There was a problem hiding this comment.
Tons of commented-out code. Is it needed? If so, why is it commented?
There was a problem hiding this comment.
This is explained in the PR description and in the file - the commented code needs to be uncommented and updated one day. For now, the slider implementation is improved in some places, but some places from the old implementation are not working yet.
| mem::forget(frp); | ||
| mem::forget(navigator); | ||
| mem::forget(root); | ||
| mem::forget(vector_editor); |
There was a problem hiding this comment.
If lifetimes of these objects are tied, shouldn't they be grouped together in a single struct?
There was a problem hiding this comment.
As agreed via Discord, let's leave it as it. It is a debug scene and we are doing so there as this is less boilerplate than creating structures. But generally, yes, we should think about managing that nicer in debug scenes in general.
* develop: Passing events to sub-widgets in List Editor and refactoring of the slider component. (#6433) Revert "Cloud/desktop mode switcher (#6308)" (#6444) Widgets integrated with graph nodes (#6347) Table Visualization and display text changes. (#6382) Skip redundant compilations (#6436) Add parse extensions to Text type. #6330 (#6404) Cloud/desktop mode switcher (#6308) Replace Table should_equal with should_equal_verbose (#6405) Rollback event handling changes for the mouse (#6396) Dashboard directory interactivity (#6279) Ability to change the execution environment between design and live. (#6341) Implementation of elements adding to List Editor and a lot of internal API (#6390) Drop method exported from WASM + removing leaks. (#6365) Turn null into UnexpectedExpression when Union type is incomplete (#6415)
Pull Request Description
Fixes #6428 .
This PR improves List Editor component and refactors the Slider component.
List Editor Improvements
It is possible now to use complex widgets as List Editor items (previously dragging them was not possible). Also, now the mouse events are passed to the items if the item is not being dragged:
Screen.Recording.2023-04-26.at.15.24.01.mov
Slider Improvements
The slider code was heavily refactored to make it use the most modern EnsoGL API. In particular:
Screen.Recording.2023-04-26.at.15.31.40.mov
However, the slider code after the update do not contain all the functionality of the old implementation. In particular, the following things do not work yet:
As the slider is not used in real places, we are keeping it as is for now, while the created changes were needed to test it's behavior with List Editor component.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.