-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snapshot Restore] Remove cloud validation for slm policy #93609
[Snapshot Restore] Remove cloud validation for slm policy #93609
Conversation
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alisonelizabeth,
thanks a lot for fixing this! Tested locally and all worked for me, code LGTM too 👍
* master: (107 commits) [Logs UI] Fix log stream data fetching (elastic#93201) [App Search] Added relevance tuning search preview (elastic#93054) [Canvas] Fix reports embeddables (elastic#93482) [ILM] Added new functional test in ILM for creating a new policy (elastic#92936) Remove direct dependency on statehood package (elastic#93592) [Maps] Track tile loading status (elastic#91585) [Discover][Doc] Improve main documentation (elastic#91854) [Upgrade Assistant] Disable UA and add prompt (elastic#92834) [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609) [Maps] Support GeometryCollections in GeoJson upload (elastic#93507) [XY Charts] fix partial histogram endzones annotations (elastic#93091) [Core] Simplify context typings (elastic#93579) [Alerting] Improving health status check (elastic#93282) [Discover] Restore context documentation (elastic#90784) [core-docs] Edits core-intro section for the new docs system (elastic#93540) add missed codeowners (elastic#89714) fetch node labels via script execution (elastic#93225) [Security Solution] Adds getMockTheme function (elastic#92840) Sort dependencies in package.json correctly (elastic#93590) [Bug] missing timepicker:quickRanges migration (elastic#93409) ...
Fixes #92990
Per #92990 (comment), we should no longer be restricting a user from adding more than one policy to a cloud-managed repository. This PR removes the validation logic we had in place for this.
Note: There was not an existing test for this validation, and since this is functionality being removed, I did not add any tests for this specific scenario. However, I did update the existing validation tests for the logistics step to be more robust.
How to test
You will need to mock the cloud environment to test this PR.
Specify the
path.repo
variable when starting ES:Add the
cluster.metadata.managed_repository
andcluster.metadata.managed_policies
settings via Console:Create a repository with the same name as your setting value (
found-snapshots
)Create a policy with the same name as your setting value (
managed-policy
)Verify you are able to create a second SLM policy with the
found-snapshots
repository without any validation errors.Release note
The Snapshot and Restore UI now allows a user to configure more than one Snapshot Lifecycle Management (SLM) policy for a cloud-managed repository.