[Upgrade Assistant] Disable UA and add prompt #92834
Conversation
alisonelizabeth
added
v8.0.0
Team:Kibana Management
|
The text seems a little long to me. Does this work? 9.0 Upgrade Assistant coming soon 8.0 Upgrade Assistant coming soon |
|
As per our discussion, here is our latest revision: 9.0 Upgrade Assistant |
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
/cc @cjcenizal @jethr0null for visibility |
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
LGTM! Great work @alisonelizabeth! I left 2 minor comments.
| <FormattedMessage | ||
| id="xpack.upgradeAssistant.emptyPrompt.upgradeAssistantDescription" | ||
| defaultMessage="The Upgrade Assistant identifies deprecated settings in your cluster and helps you | ||
| resolve issues before you upgrade. Check back here when it's time to upgrade to Elasticsearch {nextMajor}." |
There was a problem hiding this comment.
Would it make sense to say "when it's time to upgrade your stack to..."?
There was a problem hiding this comment.
Good point. I changed this to "when it's time to upgrade your Elastic Stack to XX".
There was a problem hiding this comment.
If we want this message to match how we're starting to talk about releases in blogs, maybe it should be "upgrade to Elastic X.XX."
There was a problem hiding this comment.
Latest: The Upgrade Assistant identifies deprecated settings in your cluster and helps you resolve issues before you upgrade. Check back here when it's time to upgrade to Elastic {nextMajor}.
| </EuiPageHeaderSection> | ||
| </EuiPageHeader> | ||
|
|
||
| <AppContext.Consumer> |
There was a problem hiding this comment.
You could also access http on L17 and not need the consumer here.
There was a problem hiding this comment.
Good catch! Fixed.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
# Conflicts: # x-pack/plugins/upgrade_assistant/common/constants.ts
* master: (107 commits) [Logs UI] Fix log stream data fetching (elastic#93201) [App Search] Added relevance tuning search preview (elastic#93054) [Canvas] Fix reports embeddables (elastic#93482) [ILM] Added new functional test in ILM for creating a new policy (elastic#92936) Remove direct dependency on statehood package (elastic#93592) [Maps] Track tile loading status (elastic#91585) [Discover][Doc] Improve main documentation (elastic#91854) [Upgrade Assistant] Disable UA and add prompt (elastic#92834) [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609) [Maps] Support GeometryCollections in GeoJson upload (elastic#93507) [XY Charts] fix partial histogram endzones annotations (elastic#93091) [Core] Simplify context typings (elastic#93579) [Alerting] Improving health status check (elastic#93282) [Discover] Restore context documentation (elastic#90784) [core-docs] Edits core-intro section for the new docs system (elastic#93540) add missed codeowners (elastic#89714) fetch node labels via script execution (elastic#93225) [Security Solution] Adds getMockTheme function (elastic#92840) Sort dependencies in package.json correctly (elastic#93590) [Bug] missing timepicker:quickRanges migration (elastic#93409) ...
This PR adds an empty prompt to the Upgrade Assistant that will be rendered in place of the current Upgrade Assistant UI up until the last minor before the next major release. This is to prevent users from using UA and potentially performing destructive actions and/or seeing unexpected behavior before UA has accounted for all upgrade scenarios.
Next steps:
As part of the next iteration, we will render the response from the deprecation info API, but will still not allow the user to perform any actions (e.g., reindexing).
Screenshots
On master:
On 7.x:
