Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependency on statehood package #93592

Merged
merged 4 commits into from
Mar 4, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Mar 4, 2021

Summary

We shouldn't declare a dependency on the package, the direct access of the package has been removed in #86994

@mshustov mshustov added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Mar 4, 2021
@mshustov
Copy link
Contributor Author

mshustov commented Mar 4, 2021

@elasticmachine merge upstream

@mshustov mshustov marked this pull request as ready for review March 4, 2021 16:09
@mshustov mshustov enabled auto-merge (squash) March 4, 2021 16:09
@mshustov mshustov requested a review from a team March 4, 2021 16:09
@mshustov
Copy link
Contributor Author

mshustov commented Mar 4, 2021

@elasticmachine merge upstream

@mshustov mshustov added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 4, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 3e98b10 into elastic:master Mar 4, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 4, 2021
* remove stathood deps. not used anymore

* remove direct deps on @hapi/statehood

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #93661

Successful backport PRs will be merged automatically after passing CI.

@mshustov mshustov deleted the remove-statehood-deps branch March 4, 2021 19:50
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
* master: (107 commits)
  [Logs UI] Fix log stream data fetching (elastic#93201)
  [App Search] Added relevance tuning search preview (elastic#93054)
  [Canvas] Fix reports embeddables (elastic#93482)
  [ILM] Added new functional test in ILM for creating a new policy (elastic#92936)
  Remove direct dependency on statehood package (elastic#93592)
  [Maps] Track tile loading status (elastic#91585)
  [Discover][Doc] Improve main documentation (elastic#91854)
  [Upgrade Assistant] Disable UA and add prompt (elastic#92834)
  [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609)
  [Maps] Support GeometryCollections in GeoJson upload (elastic#93507)
  [XY Charts] fix partial histogram endzones annotations (elastic#93091)
  [Core] Simplify context typings (elastic#93579)
  [Alerting] Improving health status check (elastic#93282)
  [Discover] Restore context documentation (elastic#90784)
  [core-docs] Edits core-intro section for the new docs system (elastic#93540)
  add missed codeowners (elastic#89714)
  fetch node labels via script execution (elastic#93225)
  [Security Solution] Adds getMockTheme function (elastic#92840)
  Sort dependencies in package.json correctly (elastic#93590)
  [Bug] missing timepicker:quickRanges migration (elastic#93409)
  ...
kibanamachine added a commit that referenced this pull request Mar 4, 2021
* remove stathood deps. not used anymore

* remove direct deps on @hapi/statehood

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Mikhail Shustov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backported chore release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants