[App Search] Added relevance tuning search preview #93054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonStoltz
added
v7.13.0
release_note:skip
JasonStoltz
changed the title
JasonStoltz
force-pushed
the
relevance-tuning-7
branch
from
22b7227 to
d495903
Compare
cee-chen
reviewed
Mar 3, 2021
...tions/app_search/components/relevance_tuning/relevance_tuning_form/relevance_tuning_form.tsx
Show resolved
Hide resolved
cee-chen
reviewed
Mar 3, 2021
| @@ -82,10 +84,12 @@ export const RelevanceTuning: React.FC<Props> = ({ engineBreadcrumb }) => { | |||
|
|
|||
| return ( | |||
| <EuiFlexGroup> | |||
There was a problem hiding this comment.
@daveyholler not sure if you want to weigh in on this one, but if we're following the old standalone UI it looks like this shouldn't be stretching the preview panel to match the left column height:
Suggested change
| <EuiFlexGroup> | |
| <EuiFlexGroup alignItems="flexStart"> |
Before:
...
After:
cee-chen
reviewed
Mar 3, 2021
...arch/public/applications/app_search/components/relevance_tuning/relevance_tuning_preview.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Mar 3, 2021
...arch/public/applications/app_search/components/relevance_tuning/relevance_tuning_preview.tsx
Show resolved
Hide resolved
cee-chen
reviewed
Mar 3, 2021
...arch/public/applications/app_search/components/relevance_tuning/relevance_tuning_preview.tsx
Outdated
Show resolved
Hide resolved
|
Just wanted to say thanks so much for splitting this up / making this a super small and easy to review. Seriously made a huge difference for me mentally to be able to sit down and knock it out in one sitting. 🙇♀️ |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
cee-chen
approved these changes
Mar 4, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 4, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 4, 2021
* master: (107 commits) [Logs UI] Fix log stream data fetching (elastic#93201) [App Search] Added relevance tuning search preview (elastic#93054) [Canvas] Fix reports embeddables (elastic#93482) [ILM] Added new functional test in ILM for creating a new policy (elastic#92936) Remove direct dependency on statehood package (elastic#93592) [Maps] Track tile loading status (elastic#91585) [Discover][Doc] Improve main documentation (elastic#91854) [Upgrade Assistant] Disable UA and add prompt (elastic#92834) [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609) [Maps] Support GeometryCollections in GeoJson upload (elastic#93507) [XY Charts] fix partial histogram endzones annotations (elastic#93091) [Core] Simplify context typings (elastic#93579) [Alerting] Improving health status check (elastic#93282) [Discover] Restore context documentation (elastic#90784) [core-docs] Edits core-intro section for the new docs system (elastic#93540) add missed codeowners (elastic#89714) fetch node labels via script execution (elastic#93225) [Security Solution] Adds getMockTheme function (elastic#92840) Sort dependencies in package.json correctly (elastic#93590) [Bug] missing timepicker:quickRanges migration (elastic#93409) ...
kibanamachine
added a commit
that referenced
this pull request
Mar 4, 2021
Co-authored-by: Jason Stoltzfus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the Preview section to the Relevance Tuning view
ent-search version, for comparison:
Some things to note:
Checklist
Delete any items that are not applicable to this PR.
For maintainers