Add button to view full service map #59394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smith
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
|
retest |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
ogupte
suggested changes
Mar 12, 2020
| <Button | ||
| aria-label={viewFullMapLabel} | ||
| color="text" | ||
| href={getAPMHref('/service-map', currentSearch)} |
There was a problem hiding this comment.
we should pass all of the params (useUrlParams().urlParams) in the 3rd argument to getAPMHref, otherwise it will lose filters like date/time range and environment as they navigate.
There was a problem hiding this comment.
Updated in 9987f8ba12.
smith
force-pushed
the
nls/view-full-map
branch
from
b9985e3
to
9987f8b
Compare
Closes elastic#59325. It does sometimes cause the map to not be centered when switching, which will be addressed in a separate PR as part of elastic#59164. Also add a missing prop to the popover. It was causing the focus button there to never be disabled.
smith
force-pushed
the
nls/view-full-map
branch
from
9987f8b
to
94eb1e1
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Mar 13, 2020
Closes elastic#59325. It does sometimes cause the map to not be centered when switching, which will be addressed in a separate PR as part of elastic#59164. Also add a missing prop to the popover. It was causing the focus button there to never be disabled.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 13, 2020
* master: [Alerting] extend Alert Type with names/descriptions of action variables (elastic#59756) [Ingest] Fix data source creation and double system data source (elastic#60069) Add button to view full service map (elastic#59394) unskip tests for code coverage (elastic#59725) [Ingest] Add Fleet & EPM features (elastic#59376) [Logs UI] Show navigation bar while loading source configurati… (elastic#59997) [Endpoint] ERT-82 Alerts search bar (elastic#59702) Aggregate queue types being used by Beats (elastic#59850) skip flaky suite (elastic#59541) Convert Timeline to TypeScript (elastic#59966) Make context.core required argument to context providers (elastic#59996)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59325.
It does sometimes cause the map to not be centered when switching, which will be addressed in a separate PR as part of #59164.
Change the title attributes of the controls to be tooltips.
Also add a missing prop to the popover. It was causing the focus button there to never be disabled.