[Ingest] Fix data source creation and double system data source #60069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
Feature:EPM
|
Pinging @elastic/ingest-management (Feature:EPM) |
jen-huang
commented
Mar 12, 2020
| @@ -82,6 +82,4 @@ async function addPackageToConfig( | |||
| config_id: config.id, | |||
| output_id: defaultOutput.id, | |||
| }); | |||
| // Assign it to the given agent config | |||
| await agentConfigService.assignDatasources(soClient, datasource.config_id, [datasource.id]); | |||
There was a problem hiding this comment.
Line removed as this is done in datasourceService.create
|
Now that #59376 has merged please switch this to be against master |
jen-huang
force-pushed
the
feature/ingest/ds-fixes
branch
from
ebe87bb to
be6d794
Compare
jen-huang
added
release_note:skip
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jen-huang
added a commit
that referenced
this pull request
Mar 13, 2020
…) (#60080) * Fix Internal Server Error about mapping issue when creating a data source * Fix double system datasource appearing in default config * Ensure we can never double assign same datasource ID to agent config
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 13, 2020
* master: [Alerting] extend Alert Type with names/descriptions of action variables (elastic#59756) [Ingest] Fix data source creation and double system data source (elastic#60069) Add button to view full service map (elastic#59394) unskip tests for code coverage (elastic#59725) [Ingest] Add Fleet & EPM features (elastic#59376) [Logs UI] Show navigation bar while loading source configurati… (elastic#59997) [Endpoint] ERT-82 Alerts search bar (elastic#59702) Aggregate queue types being used by Beats (elastic#59850) skip flaky suite (elastic#59541) Convert Timeline to TypeScript (elastic#59966) Make context.core required argument to context providers (elastic#59996)
jen-huang
added
the
Team:Fleet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes:
updated_onfield for agent config saved object when attempting to create a data source (step 3 in the UI)system-1packages showing in default agent config list because the datasource ID got double-assigned to the agent configSelf shipping this PR once CI is green.