Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make context.core required argument to context providers #59996

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Make context.core required argument to context providers #59996

merged 3 commits into from
Mar 12, 2020

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Mar 12, 2020

Summary

Makes plugins' code for registering context providers a little bit cleaner.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rudolf rudolf added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes labels Mar 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

rudolf
rudolf commented Mar 12, 2020
View reviewed changes
src/core/server/server.api.md
@@ -882,8 +882,10 @@ export interface IContextContainer<THandler extends HandlerFunction<any>> {
registerContext<TContextName extends keyof HandlerContextType<THandler>>(pluginOpaqueId: PluginOpaqueId, contextName: TContextName, provider: IContextProvider<THandler, TContextName>): this;
}

// Warning: (ae-forgotten-export) The symbol "PartialExceptFor" needs to be exported by the entry point index.d.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine not to expose PartialExceptFor as plugins would never need to use this type directly.

@rudolf rudolf marked this pull request as ready for review March 12, 2020 14:22
@rudolf rudolf requested review from a team as code owners March 12, 2020 14:22
mikecote
mikecote approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting changes LGTM

mshustov
mshustov approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me. However, I hope we manage to simplify the context declaration in #57674

lukasolson
lukasolson approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppArch changes LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #32742 failed 98f92b2fc2c8a22deb526a57bd5eda907c6b570a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf merged commit 80e6ff7 into elastic:master Mar 12, 2020
@rudolf rudolf deleted the required-core-context branch March 12, 2020 19:39
@rudolf rudolf mentioned this pull request Mar 12, 2020
Merged
rudolf added a commit that referenced this pull request Mar 12, 2020
@rudolf
Make context.core required argument to context providers (#59996) (#6…
d0ab211 
…0061)

* Make context.core required argument to context providers

* Refactor plugins: context.core isn't optional anymore

* Update docs
@mshustov mshustov mentioned this pull request Mar 13, 2020
Merged
7 tasks
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 13, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
b0010da 
* master:
  [Alerting] extend Alert Type with names/descriptions of action variables (elastic#59756)
  [Ingest] Fix data source creation and double system data source (elastic#60069)
  Add button to view full service map (elastic#59394)
  unskip tests for code coverage (elastic#59725)
  [Ingest] Add Fleet & EPM features (elastic#59376)
  [Logs UI] Show navigation bar while loading source configurati… (elastic#59997)
  [Endpoint] ERT-82 Alerts search bar (elastic#59702)
  Aggregate queue types being used by Beats (elastic#59850)
  skip flaky suite (elastic#59541)
  Convert Timeline to TypeScript (elastic#59966)
  Make context.core required argument to context providers (elastic#59996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasolson lukasolson lukasolson approved these changes

@mshustov mshustov mshustov approved these changes

@mikecote mikecote mikecote approved these changes

Assignees
No one assigned
Labels
chore Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rudolf @elasticmachine @kibanamachine @lukasolson @mshustov @mikecote