Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Service Maps: Navigating from the global map to the local map #59164

Closed
2 tasks
sorenlouv opened this issue Mar 3, 2020 · 6 comments
Closed
2 tasks

[APM] Service Maps: Navigating from the global map to the local map #59164

sorenlouv opened this issue Mar 3, 2020 · 6 comments
Assignees
Labels
apm:service-maps Service Map feature in APM bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.7.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Mar 3, 2020

This issue contains a couple of enhancements and bugs that occur when focusing on a service aka navigating from the global service map to the local (service specific) service map:

  • Sometimes a service that had connections on the global map, shows up without any connections in the local map. Expected outcome is that the same connections that were displayed on the global map are also displayed on the local map.
  • Navigating from global to local service map should cause the page to be re-centered on the selected service. Currently the selected service is in the top-left corner
@sorenlouv sorenlouv added [zube]: (7.7) Planned for release bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support labels Mar 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist
Copy link
Contributor

if there are no connections on the local map there should be a help text saying so, and potentially a link back to the global service map (@formgeist design?)

I did a screen example of how we might display a callout at the top of the map to help the user and link to the documentation. Perhaps, if they've navigated to the single service map from a global map, we can additionally have a "Back to full map" option.

selected service no connections

@sorenlouv
Copy link
Member Author

@formgeist Awesome! I've updated the description with your design 👍

@formgeist
Copy link
Contributor

Before I open a new implementation issue for this, I thought I'd propose a new link to the global map from any single service map, so the user always have a way to go to the full map. Not entirely sure about the copy here...

Screenshot 2020-03-04 at 13 42 37

Thoughts?

@dgieselaar
Copy link
Member

@formgeist love it!

@sorenlouv
Copy link
Member Author

sorenlouv commented Mar 4, 2020

Awesome, thanks @formgeist. I moved two of the items to separate issues: #59326 + #59325

@ogupte ogupte removed their assignment Mar 6, 2020
@smith smith self-assigned this Mar 6, 2020
smith added a commit to smith/kibana that referenced this issue Mar 12, 2020
Closes elastic#59325.

It does sometimes cause the map to not be centered when switching, which will be addressed in a separate PR as part of elastic#59164.

Also add a missing prop to the popover. It was causing the focus button there to never be disabled.
smith added a commit that referenced this issue Mar 13, 2020
Closes #59325.

It does sometimes cause the map to not be centered when switching, which will be addressed in a separate PR as part of #59164.

Also add a missing prop to the popover. It was causing the focus button there to never be disabled.
smith added a commit to smith/kibana that referenced this issue Mar 13, 2020
Closes elastic#59325.

It does sometimes cause the map to not be centered when switching, which will be addressed in a separate PR as part of elastic#59164.

Also add a missing prop to the popover. It was causing the focus button there to never be disabled.
smith added a commit that referenced this issue Mar 13, 2020
Closes #59325.

It does sometimes cause the map to not be centered when switching, which will be addressed in a separate PR as part of #59164.

Also add a missing prop to the popover. It was causing the focus button there to never be disabled.
@smith smith closed this as completed Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:service-maps Service Map feature in APM bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.7.0
Projects
None yet
Development

No branches or pull requests

6 participants