Clarify Precision function in Timelion Kibana #58031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
requested changes
Feb 19, 2020
| }), | ||
| }, | ||
| ], | ||
| help: i18n.translate('timelion.help.functions.precisionHelpText', { | ||
| defaultMessage: 'number of digits to round the decimal portion of the value to', | ||
| defaultMessage: 'The number of digists to truncate the decimal portion of the value to', |
There was a problem hiding this comment.
Thanks! Good catch, lol
nickofthyme
added
release_note:skip
nickofthyme
approved these changes
Feb 19, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
rshen91
added a commit
to rshen91/kibana
that referenced
this pull request
Feb 20, 2020
* Closes issue 26100 Co-authored-by: Elastic Machine <[email protected]>
rshen91
added a commit
that referenced
this pull request
Feb 20, 2020
* Closes issue 26100 Co-authored-by: Elastic Machine <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 21, 2020
…-out-of-legacy * 'master' of github.com:elastic/kibana: (109 commits) document difference between log record formats (elastic#57798) Expose elasticsearch config schema (elastic#57655) [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130) [SIEM] Cleans Cypress tests code (elastic#58134) fix: 🐛 make dev server Storybook builds work again (elastic#58188) Prevent core savedObjects plugin from being overridden (elastic#58193) Expose serverBasePath on client-side (elastic#58070) Fix legend sizing on area charts (elastic#58083) Drilldown plugin (elastic#58097) [skip-ci] Fix broken links to saved objects APIs in MIGRATION.md (elastic#58033) [ML] New Platform server shim: update datafeed routes (elastic#57739) Add flag for building static storybook site (elastic#58050) add monaco to kbn/ui-shared-deps and load required features for all uses (elastic#58075) [SIEM] Let us try out code owners for a little while and see what happens Add throttle param to Alerting readme (elastic#57609) [NP] Move ui/saved_objects to NP (elastic#57452) [Logs UI] Fix column reordering in settings page (elastic#58104) Fix browser date format (elastic#57714) Add filter for ILM phase to Index Management (revert elastic#45486) (elastic#57402) Clarify Precision function in Timelion Kibana (elastic#58031) ... # Conflicts: # x-pack/.i18nrc.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes issue #26100
Changed the text within
defaultMessagein the precision.js file fromNumber of digits to round each value totoThe number of digits to truncate each value to, andnumber of digits to round the decimal potion of the value totoThe number of digits to truncate the decimal portion of the value tocc @KOTungseth
Checklist
Delete any items that are not applicable to this PR.
For maintainers