Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Clarify Precision function in Timelion Kibana #26100

Closed
lcawl opened this issue Nov 22, 2018 · 2 comments
Closed

[DOCS] Clarify Precision function in Timelion Kibana #26100

lcawl opened this issue Nov 22, 2018 · 2 comments
Assignees
@KOTungseth
Labels
Feature:Timelion Timelion app and visualization good first issue low hanging fruit Team:Docs Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@lcawl
Copy link
Contributor

lcawl commented Nov 22, 2018

Per elastic/docs#444:

There seems to be a confusion with how Precision function really works.

The description of .precision only says the data is rounded, but doesn't specify a direction, like rounded down (it does imply one by using the name "precision"). If we follow normal rounding rules, 0.99 would be rounded to 1 where 0.99 with a precision of 0 would be 0 as in 0.99 with no decimal places.

I think it would be good to clarify this maybe with an example as well or a note that the excess decimals are dropped or the number is "rounded down" to precision instead of just "rounded".
@lcawl lcawl added Team:Docs Feature:Timelion Timelion app and visualization v7.0.0 labels Nov 22, 2018
@lcawl lcawl mentioned this issue Nov 22, 2018
Closed
@schersh
Copy link
Contributor

schersh commented Mar 18, 2019

Note: This issue is related to help text in the UI

Screen Shot 2019-03-15 at 11 48 30 AM

Screen Shot 2019-03-15 at 11 48 30 AM

@KOTungseth KOTungseth self-assigned this Sep 18, 2019
@KOTungseth KOTungseth removed their assignment Dec 2, 2019
@KOTungseth KOTungseth added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Dec 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@KOTungseth KOTungseth mentioned this issue Dec 2, 2019
Closed
@KOTungseth KOTungseth self-assigned this Dec 6, 2019
@timroes timroes added the good first issue low hanging fruit label Dec 10, 2019
@rshen91 rshen91 mentioned this issue Feb 19, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KOTungseth KOTungseth

Labels
Feature:Timelion Timelion app and visualization good first issue low hanging fruit Team:Docs Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates precision definition KOTungseth/kibana
6 participants
@snide @timroes @schersh @elasticmachine @lcawl @KOTungseth