Updates precision definition #52024
Closed
Updates precision definition #52024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KOTungseth
added
review
v7.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
suggested changes
Dec 2, 2019
There was a problem hiding this comment.
This has the unintended side effect of not translating the text, so left a comment on how to keep the translation.
Also, unlike docs changes, we don't backport as far for regular changes because we don't release older versions frequently. This should only be backported to 7.x
| @@ -31,14 +30,10 @@ export default new Chainable('precision', { | |||
| { | |||
| name: 'precision', | |||
| types: ['number'], | |||
| help: i18n.translate('timelion.help.functions.precision.args.precisionHelpText', { | |||
| defaultMessage: 'Number of digits to round each value to', | |||
| }), | |||
There was a problem hiding this comment.
You can keep the i18n ID, but you will need to search for the same id timelion.help.functions.precision.args.precisionHelpText in the translation files and delete the translation.
There was a problem hiding this comment.
@wylieconlon when you say i18n ID, do you mean lines 20, 34, and 39? Or just line 20?
Also, where are the translation files?
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #26100