Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] New Platform server shim: update datafeed routes #57739

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Feb 14, 2020

Summary

Related meta issue: #49743

Updates all job validation routes to use new platform router

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner February 14, 2020 23:26
@alvarezmelissa87 alvarezmelissa87 self-assigned this Feb 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this pull request Feb 14, 2020
78 tasks
@alvarezmelissa87 alvarezmelissa87 changed the title [ML] New Platform server shim: update datafeed routes WIP [ML] New Platform server shim: update datafeed routes Feb 15, 2020
@alvarezmelissa87 alvarezmelissa87 changed the title WIP [ML] New Platform server shim: update datafeed routes [ML] New Platform server shim: update datafeed routes Feb 15, 2020
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-new-platform-datafeed-routes branch from 6f7a89b to af68fcd Compare February 18, 2020 16:58
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-new-platform-datafeed-routes branch from 19d7661 to 6d1424a Compare February 20, 2020 16:29
@alvarezmelissa87
Copy link
Contributor Author

Would you be up for taking a look when you get a chance? cc @walterra , @darnautov

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87
Copy link
Contributor Author

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #27446 succeeded 19d7661e83505a781651b370e0e250b46f4b1481
  • 💔 Build #27401 failed af68fcdbd7e1ce21f9f3b4c84042473e7973f20e
  • 💔 Build #27133 failed 6f7a89b2cc7f056dc509c8f2fcda87dcb94d251b
  • 💔 Build #27004 failed a62d17ddce12edcc3cae2695c235ef214c12096e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 merged commit 3f4640b into elastic:master Feb 20, 2020
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Feb 20, 2020
* convert datafeed routes to new platfrom

* update datafeed schema

* consolidate datafeedConfig schema for datafeed + job validation
@alvarezmelissa87 alvarezmelissa87 deleted the ml-new-platform-datafeed-routes branch February 20, 2020 20:51
alvarezmelissa87 added a commit that referenced this pull request Feb 20, 2020
* convert datafeed routes to new platfrom

* update datafeed schema

* consolidate datafeedConfig schema for datafeed + job validation
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 21, 2020
…-out-of-legacy

* 'master' of github.com:elastic/kibana: (109 commits)
  document difference between log record formats (elastic#57798)
  Expose elasticsearch config schema (elastic#57655)
  [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130)
  [SIEM] Cleans Cypress tests code (elastic#58134)
  fix: 🐛 make dev server Storybook builds work again (elastic#58188)
  Prevent core savedObjects plugin from being overridden (elastic#58193)
  Expose serverBasePath on client-side (elastic#58070)
  Fix legend sizing on area charts (elastic#58083)
  Drilldown plugin (elastic#58097)
  [skip-ci] Fix broken links to saved objects APIs in MIGRATION.md (elastic#58033)
  [ML] New Platform server shim: update datafeed routes (elastic#57739)
  Add flag for building static storybook site (elastic#58050)
  add monaco to kbn/ui-shared-deps and load required features for all uses (elastic#58075)
  [SIEM] Let us try out code owners for a little while and see what happens
  Add throttle param to Alerting readme (elastic#57609)
  [NP] Move ui/saved_objects to NP (elastic#57452)
  [Logs UI]  Fix column reordering in settings page (elastic#58104)
  Fix browser date format (elastic#57714)
  Add filter for ILM phase to Index Management (revert elastic#45486) (elastic#57402)
  Clarify Precision function in Timelion Kibana (elastic#58031)
  ...

# Conflicts:
#	x-pack/.i18nrc.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration :ml release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants