Add filter for ILM phase to Index Management (revert #45486) #57402

cjcenizal · 2020-02-12T00:32:12Z

CC @sebelga I will block this on #57295, and resolve merge conflicts on my end once your PR is in master.

Release note

We've added a filter to Index Management that lets you see indices grouped by the lifecycle phase they're in: hot, warm, cold, and delete.

(See gif and screenshot below).

Background

elastic/elasticsearch#51631 fixed the ES API so that the phase is now reported as users expect, instead of transiently being in a phase and then changing to "completed". With the API giving us the information we need, we can now fulfill the filtering functionality we've been fighting for.

Testing

To test, execute these requests in Dev Tools:

# Set a faster poll interval to see ILM changes in Index Management sooner
PUT /_cluster/settings
{
  "transient": {
    "logger.org.elasticsearch.xpack.core.indexlifecycle": "TRACE",
    "logger.org.elasticsearch.xpack.indexlifecycle": "TRACE",
    "logger.org.elasticsearch.xpack.core.ilm": "TRACE",
    "logger.org.elasticsearch.xpack.ilm": "TRACE",
    "indices.lifecycle.poll_interval": "10s"
  }
}

# Later, replace rollover's "max_docs": 1 with "max_age": "1s" to see rollover in action
PUT /_ilm/policy/full
{
  "policy": {
    "phases" : {
      "hot" : {
        "min_age" : "0ms",
        "actions" : {
          "rollover" : {
            "max_docs": 1
          }
        }
      },
      "warm" : {
        "min_age" : "1m",
        "actions" : {
          "forcemerge" : {
            "max_num_segments" : 1
          },
          "shrink" : {
            "number_of_shards" : 1
          }
        }
      },
      "cold" : {
        "min_age" : "1m",
        "actions" : {
          "freeze": {}
        }
      }
    }
  }
}

PUT _template/test
{
  "index_patterns": ["test-*"],
  "settings": {
    "number_of_shards": 3,
    "number_of_replicas": 0,
    "index.lifecycle.name": "full",
    "index.lifecycle.rollover_alias": "test-alias"
  }
}

PUT /test-000001
{
  "aliases": {
    "test-alias": {
      "is_write_index": true
    }
  }
}

POST test-alias/_doc
{
  "foo": "foo"
}

Then edit and execute the second request to update the policy per the comment, changing the rollover config's "max_docs": 1 to "max_age": "1s". Refresh Index Management repeatedly and you'll see rollover indices start spawning into existence. After a minute, some will be in the warm phase. After a couple minutes, some will be in the cold phase. Then you can use the filter like this:

You can also add a delete phase and refresh to try to catch an index in this phase before the delete action completes and it disappears forever.

PUT /_ilm/policy/full
{
  "policy": {
    "phases" : {
      "hot" : {
        "min_age" : "0ms",
        "actions" : {
          "rollover" : {
            "max_age": "1s" 
          }
        }
      },
      "delete": {
        "min_age": "1m",
        "actions": {
          "delete": {}
        }
      }
    }
  }
}

elasticmachine · 2020-02-12T00:32:15Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

sebelga · 2020-02-12T06:37:22Z

Awesome! Shouldn't the "Delete" phase be the last item in the dropdown instead of the first one as in the screenshot?

[EDIT] OK I just see in the gif that the selected value comes first in the list once selected 👍

jloleysens

Tested locally and worked as explained the description!

Great work @cjcenizal , this really nice functionality to see in action!

P.S.
I assume that in the PR description I was supposed to change "min_age" not "max_age"?

cjcenizal · 2020-02-12T22:33:05Z

I assume that in the PR description I was supposed to change "min_age" not "max_age"?

No, max_age is correct for the hot phase.

kibanamachine · 2020-02-20T08:14:55Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 4984bff
Flaky suites:
- xpack-kibana-ciGroup3

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/feature_controls/discover_security·ts.discover feature controls security global discover all privileges allow saving via the saved query management component popover with no query loaded

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 17 times on tracked branches: https://github.com/elastic/kibana/issues/45348

[00:00:00]       │
[00:03:47]         └-: discover
[00:03:47]           └-> "before all" hook
[00:03:47]           └-: feature controls
[00:03:47]             └-> "before all" hook
[00:03:47]             └-: security
[00:03:47]               └-> "before all" hook
[00:03:47]               └-> "before all" hook
[00:03:47]                 │ info [discover/feature_controls/security] Loading "mappings.json"
[00:03:47]                 │ info [discover/feature_controls/security] Loading "data.json"
[00:03:47]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] [.kibana_2/06B3D0c0QaGUFg7DNDnvJg] deleting index
[00:03:47]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] [.kibana_1/MsZZACkmSPuNI8V3uH4EyA] deleting index
[00:03:47]                 │ info [discover/feature_controls/security] Deleted existing index [".kibana_2",".kibana_1"]
[00:03:47]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:03:47]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]]).
[00:03:47]                 │ info [discover/feature_controls/security] Created index ".kibana"
[00:03:47]                 │ debg [discover/feature_controls/security] ".kibana" settings {"index":{"number_of_shards":"1","auto_expand_replicas":"0-1","number_of_replicas":"0"}}
[00:03:47]                 │ info [discover/feature_controls/security] Indexed 3 docs into ".kibana"
[00:03:49]                 │ info Creating index .kibana_2.
[00:03:49]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:03:49]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] updating number_of_replicas to [0] for indices [.kibana_2]
[00:03:49]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_2][0]]]).
[00:03:49]                 │ info Reindexing .kibana to .kibana_1
[00:03:49]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:03:49]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] updating number_of_replicas to [0] for indices [.kibana_1]
[00:03:49]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]]).
[00:03:49]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] 4593 finished with response BulkByScrollResponse[took=52.3ms,timed_out=false,sliceId=null,updated=0,created=3,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:03:50]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] [.kibana/uB-HcURTRhWxffy05iyqtw] deleting index
[00:03:50]                 │ info Migrating .kibana_1 saved objects to .kibana_2
[00:03:50]                 │ debg Migrating saved objects index-pattern:logstash-*, config:6.0.0, query:okjpgs
[00:03:50]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] [.kibana_2/V3LUW-JSRLWdwKNSV7Qs6Q] update_mapping [_doc]
[00:03:50]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] [.kibana_2/V3LUW-JSRLWdwKNSV7Qs6Q] update_mapping [_doc]
[00:03:50]                 │ info Pointing alias .kibana to .kibana_2.
[00:03:50]                 │ info Finished in 828ms.
[00:03:50]                 │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:03:50]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] [.kibana_2/V3LUW-JSRLWdwKNSV7Qs6Q] update_mapping [_doc]
[00:03:51]                 │ info [logstash_functional] Loading "mappings.json"
[00:03:51]                 │ info [logstash_functional] Loading "data.json.gz"
[00:03:51]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:03:51]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:03:51]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:03:53]                 │ debg SecurityPage.forceLogout
[00:03:53]                 │ debg Find.existsByDisplayedByCssSelector('.login-form') with timeout=100
[00:03:53]                 │ debg --- retry.tryForTime error: .login-form is not displayed
[00:03:54]                 │ debg Redirecting to /logout to force the logout
[00:03:54]                 │ debg Waiting on the login form to appear
[00:03:54]                 │ debg Waiting up to 100000ms for login form...
[00:03:54]                 │ debg Find.existsByDisplayedByCssSelector('.login-form') with timeout=2500
[00:03:54]                 │ debg browser[INFO] http://localhost:6131/logout?_t=1582181175272 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:54]                 │
[00:03:54]                 │ debg browser[INFO] http://localhost:6131/bundles/app/logout/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:59]                 │ debg --- retry.tryForTime error: .login-form is not displayed
[00:04:00]                 │ debg Find.existsByDisplayedByCssSelector('.login-form') with timeout=2500
[00:04:03]                 │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-20T06:46:22Z
[00:04:03]                 │        Adding connection to http://localhost:6131/elasticsearch
[00:04:03]                 │
[00:04:03]                 │      "
[00:04:03]                 │ debg browser[INFO] http://localhost:6131/login?_t=1582181175272 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:03]                 │
[00:04:03]                 │ debg browser[INFO] http://localhost:6131/bundles/app/login/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:03]                 │ debg --- retry.tryForTime error: .login-form is not displayed
[00:04:04]                 │ debg Find.existsByDisplayedByCssSelector('.login-form') with timeout=2500
[00:04:07]                 │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-20T06:46:27Z
[00:04:07]                 │        Adding connection to http://localhost:6131/elasticsearch
[00:04:07]                 │
[00:04:07]                 │      "
[00:04:07]               └-: global discover all privileges
[00:04:07]                 └-> "before all" hook
[00:04:07]                 └-> "before all" hook
[00:04:07]                   │ debg creating role global_discover_all_role
[00:04:07]                   │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] added role [global_discover_all_role]
[00:04:07]                   │ debg created role global_discover_all_role
[00:04:07]                   │ debg creating user global_discover_all_user
[00:04:07]                   │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1582178778800798156] added user [global_discover_all_user]
[00:04:07]                   │ debg created user global_discover_all_user
[00:04:07]                   │ debg navigating to login url: http://localhost:6131/login
[00:04:07]                   │ debg Navigate to: http://localhost:6131/login
[00:04:07]                   │ debg ... sleep(700) start
[00:04:07]                   │ debg browser[INFO] http://localhost:6131/login?_t=1582181188399 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:07]                   │
[00:04:07]                   │ debg browser[INFO] http://localhost:6131/bundles/app/login/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:08]                   │ debg ... sleep(700) end
[00:04:08]                   │ debg returned from get, calling refresh
[00:04:11]                   │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-20T06:46:31Z
[00:04:11]                   │        Adding connection to http://localhost:6131/elasticsearch
[00:04:11]                   │
[00:04:11]                   │      "
[00:04:11]                   │ debg browser[INFO] http://localhost:6131/login?_t=1582181188399 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:11]                   │
[00:04:11]                   │ debg browser[INFO] http://localhost:6131/bundles/app/login/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:11]                   │ debg currentUrl = http://localhost:6131/login
[00:04:11]                   │          appUrl = http://localhost:6131/login
[00:04:11]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:13]                   │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-20T06:46:33Z
[00:04:13]                   │        Adding connection to http://localhost:6131/elasticsearch
[00:04:13]                   │
[00:04:13]                   │      "
[00:04:13]                   │ debg ... sleep(501) start
[00:04:13]                   │ debg ... sleep(501) end
[00:04:13]                   │ debg in navigateTo url = http://localhost:6131/login#/
[00:04:13]                   │ debg TestSubjects.exists(statusPageContainer)
[00:04:13]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:04:16]                   │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:04:17]                   │ debg TestSubjects.setValue(loginUsername, global_discover_all_user)
[00:04:17]                   │ debg TestSubjects.click(loginUsername)
[00:04:17]                   │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:04:17]                   │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:04:17]                   │ debg TestSubjects.setValue(loginPassword, global_discover_all_user-password)
[00:04:17]                   │ debg TestSubjects.click(loginPassword)
[00:04:17]                   │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:04:17]                   │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:04:17]                   │ debg TestSubjects.click(loginSubmit)
[00:04:17]                   │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:04:17]                   │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:04:18]                   │ debg Waiting up to 20000ms for logout button visible...
[00:04:18]                   │ debg TestSubjects.exists(userMenuButton)
[00:04:18]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:04:21]                   │ debg browser[INFO] http://localhost:6131/app/kibana 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:21]                   │
[00:04:21]                   │ debg browser[INFO] http://localhost:6131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:21]                   │ debg --- retry.tryForTime error: [data-test-subj="userMenuButton"] is not displayed
[00:04:22]                   │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-20T06:46:43Z
[00:04:22]                   │        Adding connection to http://localhost:6131/elasticsearch
[00:04:22]                   │
[00:04:22]                   │      "
[00:04:22]                   │ debg TestSubjects.exists(userMenuButton)
[00:04:22]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:04:24]                   │ debg TestSubjects.exists(userMenu)
[00:04:24]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=2500
[00:04:27]                   │ debg --- retry.tryForTime error: [data-test-subj="userMenu"] is not displayed
[00:04:28]                   │ debg TestSubjects.click(userMenuButton)
[00:04:28]                   │ debg Find.clickByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:04:28]                   │ debg Find.findByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:04:28]                   │ debg Waiting up to 20000ms for user menu opened...
[00:04:28]                   │ debg TestSubjects.exists(userMenu)
[00:04:28]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=2500
[00:04:28]                   │ debg TestSubjects.exists(userMenu > logoutLink)
[00:04:28]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"] [data-test-subj="logoutLink"]') with timeout=2500
[00:04:28]                 └-> shows discover navlink
[00:04:28]                   └-> "before each" hook: global before each
[00:04:28]                   │ debg TestSubjects.find(navDrawer)
[00:04:28]                   │ debg Find.findByCssSelector('[data-test-subj="navDrawer"]') with timeout=10000
[00:04:28]                   └- ✓ pass  (31ms) "discover feature controls security global discover all privileges shows discover navlink"
[00:04:28]                 └-> shows save button
[00:04:28]                   └-> "before each" hook: global before each
[00:04:28]                   │ debg navigating to discover url: http://localhost:6131/app/kibana#/discover
[00:04:28]                   │ debg Navigate to: http://localhost:6131/app/kibana#/discover
[00:04:28]                   │ debg ... sleep(700) start
[00:04:28]                   │ debg browser[INFO] http://localhost:6131/app/kibana?_t=1582181209395#/discover 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:28]                   │
[00:04:28]                   │ debg browser[INFO] http://localhost:6131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:29]                   │ debg ... sleep(700) end
[00:04:29]                   │ debg returned from get, calling refresh
[00:04:29]                   │ debg browser[INFO] http://localhost:6131/app/kibana?_t=1582181209395#/discover 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:29]                   │
[00:04:29]                   │ debg browser[INFO] http://localhost:6131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:30]                   │ debg currentUrl = http://localhost:6131/app/kibana#/discover
[00:04:30]                   │          appUrl = http://localhost:6131/app/kibana#/discover
[00:04:30]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:34]                   │ debg TestSubjects.find(kibanaChrome)
[00:04:34]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:04:34]                   │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-20T06:46:54Z
[00:04:34]                   │        Adding connection to http://localhost:6131/elasticsearch
[00:04:34]                   │
[00:04:34]                   │      "
[00:04:34]                   │ debg ... sleep(501) start
[00:04:35]                   │ debg ... sleep(501) end
[00:04:35]                   │ debg in navigateTo url = http://localhost:6131/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:04:35]                   │ debg --- retry.try error: URL changed, waiting for it to settle
[00:04:36]                   │ debg ... sleep(501) start
[00:04:36]                   │ debg ... sleep(501) end
[00:04:36]                   │ debg in navigateTo url = http://localhost:6131/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:04:36]                   │ debg TestSubjects.exists(statusPageContainer)
[00:04:36]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:04:39]                   │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:04:39]                   │ debg TestSubjects.exists(discoverSaveButton)
[00:04:39]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="discoverSaveButton"]') with timeout=20000
[00:04:39]                   └- ✓ pass  (11.4s) "discover feature controls security global discover all privileges shows save button"
[00:04:39]                 └-> doesn't show read-only badge
[00:04:39]                   └-> "before each" hook: global before each
[00:04:39]                   │ debg TestSubjects.missingOrFail(headerBadge)
[00:04:39]                   │ debg Find.waitForDeletedByCssSelector('[data-test-subj="headerBadge"]') with timeout=2500
[00:04:40]                   └- ✓ pass  (543ms) "discover feature controls security global discover all privileges doesn't show read-only badge"
[00:04:40]                 └-> Permalinks shows create short-url button
[00:04:40]                   └-> "before each" hook: global before each
[00:04:40]                   │ debg openShareMenuItem title:Permalinks
[00:04:40]                   │ debg TestSubjects.exists(shareContextMenu)
[00:04:40]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="shareContextMenu"]') with timeout=2500
[00:04:42]                   │ debg --- retry.tryForTime error: [data-test-subj="shareContextMenu"] is not displayed
[00:04:43]                   │ debg TestSubjects.click(shareTopNavButton)
[00:04:43]                   │ debg Find.clickByCssSelector('[data-test-subj="shareTopNavButton"]') with timeout=10000
[00:04:43]                   │ debg Find.findByCssSelector('[data-test-subj="shareTopNavButton"]') with timeout=10000
[00:04:43]                   │ debg Find.findByCssSelector('div.euiContextMenuPanel') with timeout=10000
[00:04:43]                   │ debg TestSubjects.click(sharePanel-Permalinks)
[00:04:43]                   │ debg Find.clickByCssSelector('[data-test-subj="sharePanel-Permalinks"]') with timeout=10000
[00:04:43]                   │ debg Find.findByCssSelector('[data-test-subj="sharePanel-Permalinks"]') with timeout=10000
[00:04:43]                   │ debg Find.waitForElementStale with timeout=10000
[00:04:43]                   │ debg TestSubjects.exists(createShortUrl)
[00:04:43]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="createShortUrl"]') with timeout=120000
[00:04:43]                   │ debg TestSubjects.click(shareTopNavButton)
[00:04:43]                   │ debg Find.clickByCssSelector('[data-test-subj="shareTopNavButton"]') with timeout=10000
[00:04:43]                   │ debg Find.findByCssSelector('[data-test-subj="shareTopNavButton"]') with timeout=10000
[00:04:43]                   └- ✓ pass  (3.5s) "discover feature controls security global discover all privileges Permalinks shows create short-url button"
[00:04:43]                 └-> allow saving via the saved query management component popover with no query loaded
[00:04:43]                   └-> "before each" hook: global before each
[00:04:43]                   │ debg TestSubjects.exists(saved-query-management-popover)
[00:04:43]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="saved-query-management-popover"]') with timeout=2500
[00:04:46]                   │ debg --- retry.tryForTime error: [data-test-subj="saved-query-management-popover"] is not displayed
[00:04:46]                   │ debg TestSubjects.click(saved-query-management-popover-button)
[00:04:46]                   │ debg Find.clickByCssSelector('[data-test-subj="saved-query-management-popover-button"]') with timeout=10000
[00:04:46]                   │ debg Find.findByCssSelector('[data-test-subj="saved-query-management-popover-button"]') with timeout=10000
[00:04:47]                   │ debg TestSubjects.click(saved-query-management-save-button)
[00:04:47]                   │ debg Find.clickByCssSelector('[data-test-subj="saved-query-management-save-button"]') with timeout=10000
[00:04:47]                   │ debg Find.findByCssSelector('[data-test-subj="saved-query-management-save-button"]') with timeout=10000
[00:04:47]                   │ debg TestSubjects.exists(saveQueryForm)
[00:04:47]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="saveQueryForm"]') with timeout=120000
[00:04:49]                   │ debg --- retry.tryForTime error: [data-test-subj="saveQueryForm"] is not displayed
[00:04:52]                   │ debg --- retry.tryForTime failed again with the same message...
[00:04:55]                   │ debg --- retry.tryForTime failed again with the same message...
[00:04:58]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:01]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:04]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:07]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:10]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:13]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:17]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:20]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:23]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:26]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:29]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:32]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:35]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:38]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:41]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:44]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:47]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:50]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:53]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:56]                   │ debg --- retry.tryForTime failed again with the same message...
[00:05:59]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:02]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:05]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:08]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:11]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:14]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:17]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:20]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:23]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:26]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:29]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:32]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:36]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:39]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:42]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:45]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:48]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:48]                   │ debg --- retry.try error: expected testSubject(saveQueryForm) to exist
[00:06:49]                   │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/discover feature controls security global discover all privileges allow saving via the saved query management component popover with no query loaded.png"
[00:06:49]                   │ info Current URL is: http://localhost:6131/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:06:49]                   │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/discover feature controls security global discover all privileges allow saving via the saved query management component popover with no query loaded.html
[00:06:49]                   └- ✖ fail: "discover feature controls security global discover all privileges allow saving via the saved query management component popover with no query loaded"
[00:06:49]                   │

Stack Trace

Error: retry.try timeout: Error: expected testSubject(saveQueryForm) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/test_subjects.ts:60:15)
    at onFailure (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:68:13)

History

💚 Build #26365 succeeded 6759a33
💔 Build #26070 failed 41ab4b8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…#58145) Co-authored-by: Elastic Machine <[email protected]>

…-out-of-legacy * 'master' of github.com:elastic/kibana: (109 commits) document difference between log record formats (elastic#57798) Expose elasticsearch config schema (elastic#57655) [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130) [SIEM] Cleans Cypress tests code (elastic#58134) fix: 🐛 make dev server Storybook builds work again (elastic#58188) Prevent core savedObjects plugin from being overridden (elastic#58193) Expose serverBasePath on client-side (elastic#58070) Fix legend sizing on area charts (elastic#58083) Drilldown plugin (elastic#58097) [skip-ci] Fix broken links to saved objects APIs in MIGRATION.md (elastic#58033) [ML] New Platform server shim: update datafeed routes (elastic#57739) Add flag for building static storybook site (elastic#58050) add monaco to kbn/ui-shared-deps and load required features for all uses (elastic#58075) [SIEM] Let us try out code owners for a little while and see what happens Add throttle param to Alerting readme (elastic#57609) [NP] Move ui/saved_objects to NP (elastic#57452) [Logs UI] Fix column reordering in settings page (elastic#58104) Fix browser date format (elastic#57714) Add filter for ILM phase to Index Management (revert elastic#45486) (elastic#57402) Clarify Precision function in Timelion Kibana (elastic#58031) ... # Conflicts: # x-pack/.i18nrc.json

Add filter for ILM phase to Index Management (reverting elastic#45486).

41ab4b8

cjcenizal added blocked enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.7.0 labels Feb 12, 2020

cjcenizal requested a review from jloleysens February 12, 2020 00:32

cjcenizal mentioned this pull request Feb 12, 2020

Restore index lifecycle phase filter #54006

Closed

cjcenizal added the release_note:enhancement label Feb 12, 2020

jloleysens approved these changes Feb 12, 2020

View reviewed changes

Update snapshot.

6759a33

jloleysens mentioned this pull request Feb 13, 2020

[SearchProfiler] Sharded Index renders weirdly and with React errors #57560

Closed

Merge branch 'master' into ilm/add-index-management-phase-filter

4984bff

cjcenizal removed blocked enhancement New value added to drive a business result labels Feb 20, 2020

cjcenizal merged commit c3001c4 into elastic:master Feb 20, 2020

cjcenizal deleted the ilm/add-index-management-phase-filter branch February 20, 2020 16:27

cjcenizal mentioned this pull request Feb 20, 2020

[7.x] Add filter for ILM phase to Index Management (revert #45486) (#57402) #58145

Merged

cjcenizal added a commit that referenced this pull request Feb 21, 2020

Add filter for ILM phase to Index Management (revert #45486) (#57402) (…

916aa7b

…#58145) Co-authored-by: Elastic Machine <[email protected]>

cjcenizal mentioned this pull request Mar 24, 2020

Add "Phase" column to Index Management indices table #61119

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add filter for ILM phase to Index Management (revert #45486) #57402

Add filter for ILM phase to Index Management (revert #45486) #57402

cjcenizal commented Feb 12, 2020 •

edited

Loading

elasticmachine commented Feb 12, 2020

sebelga commented Feb 12, 2020 •

edited

Loading

jloleysens left a comment

cjcenizal commented Feb 12, 2020

kibanamachine commented Feb 20, 2020

Standard Out

Stack Trace

Add filter for ILM phase to Index Management (revert #45486) #57402

Add filter for ILM phase to Index Management (revert #45486) #57402

Conversation

cjcenizal commented Feb 12, 2020 • edited Loading

Release note

Background

Testing

elasticmachine commented Feb 12, 2020

sebelga commented Feb 12, 2020 • edited Loading

jloleysens left a comment

Choose a reason for hiding this comment

cjcenizal commented Feb 12, 2020

kibanamachine commented Feb 20, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

History

cjcenizal commented Feb 12, 2020 •

edited

Loading

sebelga commented Feb 12, 2020 •

edited

Loading