-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] update monitor list configs for mobile view #43218
Merged
shahzad31
merged 2 commits into
elastic:master
from
shahzad31:fix/issue-40579-inconsistent-use-of-expandable-row-component
Aug 15, 2019
Merged
[Uptime] update monitor list configs for mobile view #43218
shahzad31
merged 2 commits into
elastic:master
from
shahzad31:fix/issue-40579-inconsistent-use-of-expandable-row-component
Aug 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
shahzad31
force-pushed
the
fix/issue-40579-inconsistent-use-of-expandable-row-component
branch
from
August 14, 2019 10:19
6675b36
to
e3991a7
Compare
💚 Build Succeeded |
justinkambic
approved these changes
Aug 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
shahzad31
deleted the
fix/issue-40579-inconsistent-use-of-expandable-row-component
branch
August 15, 2019 09:36
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 15, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (50 commits) [Uptime] update monitor list configs for mobile view (elastic#43218) [APM] Local UI filters (elastic#41588) [Code] Upgrade ctags langserver (elastic#43252) [Code] show multiple definition results in panel (elastic#43249) Adds Metric Type to full screen launch tracking (elastic#42692) [Canvas] Convert Autocomplete to Typescript (elastic#42502) [telemetry] add spacesEnabled config back to xpack_main (elastic#43312) [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151) Add TLS client authentication support. (elastic#43090) [csp] Telemetry for csp configuration (elastic#43223) [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804) docs: add tip on agent config in a dt (elastic#43301) [ML] Adding bucket span estimator to new wizards (elastic#43288) disable flaky tests (elastic#43017) Fix percy target branch for PRs (elastic#43160) [ML] Adding post create job options (elastic#43205) Restore discover histogram selection triggering fetch (elastic#43097) Per panel time range (elastic#43153) [Infra UI] Add APM to Metadata Endpoint (elastic#42197) Sentence case copy changes (elastic#43215) ...
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Sep 10, 2019
* update monitor list configs for mobile view * [uptime] update unit test snapshot
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Sep 10, 2019
* update monitor list configs for mobile view * [uptime] update unit test snapshot
shahzad31
added a commit
that referenced
this pull request
Sep 11, 2019
shahzad31
added a commit
that referenced
this pull request
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: #40579
Improve monitor list view for mobile and as well as align it with EUI implementation and guidelines
before this PR it looked like this
after PR it will be like this
Checklist