-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per panel time range #43153
Per panel time range #43153
Conversation
💔 Build Failed |
Pinging @elastic/kibana-app-arch |
2274cd4
to
4e69320
Compare
💔 Build Failed |
e3b330a
to
aa0698c
Compare
💔 Build Failed |
d5ea540
to
18b3c1b
Compare
18b3c1b
to
62cb62f
Compare
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments about await
ing isCompatible()
, otherwise LGTM.
Ran locally on Mac/Chrome.
...k/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_action.test.ts
Show resolved
Hide resolved
...k/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_action.test.ts
Outdated
Show resolved
Hide resolved
...k/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_action.test.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_action.tsx
Show resolved
Hide resolved
} | ||
)} | ||
> | ||
<EuiSuperDatePicker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know we have "super" date picker.
x-pack/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_badge.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_action.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
* Per panel time range * Added tests and fixed lack of await check for incompatibility * Remove a couple more unneccessary `anys`
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (50 commits) [Uptime] update monitor list configs for mobile view (elastic#43218) [APM] Local UI filters (elastic#41588) [Code] Upgrade ctags langserver (elastic#43252) [Code] show multiple definition results in panel (elastic#43249) Adds Metric Type to full screen launch tracking (elastic#42692) [Canvas] Convert Autocomplete to Typescript (elastic#42502) [telemetry] add spacesEnabled config back to xpack_main (elastic#43312) [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151) Add TLS client authentication support. (elastic#43090) [csp] Telemetry for csp configuration (elastic#43223) [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804) docs: add tip on agent config in a dt (elastic#43301) [ML] Adding bucket span estimator to new wizards (elastic#43288) disable flaky tests (elastic#43017) Fix percy target branch for PRs (elastic#43160) [ML] Adding post create job options (elastic#43205) Restore discover histogram selection triggering fetch (elastic#43097) Per panel time range (elastic#43153) [Infra UI] Add APM to Metadata Endpoint (elastic#42197) Sentence case copy changes (elastic#43215) ...
Summary
Each panel on a dashboard can now be configured to show a custom time range, independent from the global one. Just go to the menu options and select
Customize time range
. If the panel's time range is different than what is showing in the global time picker, it will contain a visible badge showing the date.fixes #17776 and #3578