Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore discover histogram selection triggering fetch #43097

Conversation

kertal
Copy link
Member

@kertal kertal commented Aug 12, 2019

Summary

When selecting a period in the discover histogram, no fetch was triggered, no new data was requested. The user had to submit the form manually. Fixes #42583

kibana-discover-histogram-bug

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@kertal kertal self-assigned this Aug 12, 2019
@kertal kertal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@@ -157,9 +159,9 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.visualize.waitForVisualization();

const newDurationHours = await PageObjects.timePicker.getTimeDurationInHours();
if (newDurationHours < 1 || newDurationHours >= 5) {
throw new Error(`expected new duration of ${newDurationHours} hours to be between 1 and 5 hours`);
}
Copy link
Member Author

@kertal kertal Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dear @ryankeairns, just wanted to know if there's a reason to check a newDurationHours value to be lower then 1 or greater than 5 to fail. Rounding the value always returned 3 so far (tested locally + Jenkins )

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes in Chrome Version 76.0.3809.100 (Official Build) (64-bit), Safari Version 12.1.2 (14607.3.9) and Firefox 68.0.1 (64-bit) and the search request is issued when selecting on the histogram.
Without the fix, the selection does not trigger a fetch request.
Code LGTM.

…tore-discover-histogram-brush-trigger-refresh
Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kertal kertal merged commit 6da05e0 into elastic:master Aug 14, 2019
kertal added a commit to kertal/kibana that referenced this pull request Aug 14, 2019
* Listen to timefilter fetch event to start fetching

* Improve functional test to catch error
kertal added a commit to kertal/kibana that referenced this pull request Aug 14, 2019
* Listen to timefilter fetch event to start fetching

* Improve functional test to catch error
kertal added a commit that referenced this pull request Aug 14, 2019
* Listen to timefilter fetch event to start fetching

* Improve functional test to catch error
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 15, 2019
…p-metrics-selectall

* 'master' of github.com:elastic/kibana: (50 commits)
  [Uptime] update monitor list configs for mobile view (elastic#43218)
  [APM] Local UI filters (elastic#41588)
  [Code] Upgrade ctags langserver (elastic#43252)
  [Code] show multiple definition results in panel (elastic#43249)
  Adds Metric Type to full screen launch tracking (elastic#42692)
  [Canvas] Convert Autocomplete to Typescript (elastic#42502)
  [telemetry] add spacesEnabled config back to xpack_main (elastic#43312)
  [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151)
  Add TLS client authentication support. (elastic#43090)
  [csp] Telemetry for csp configuration (elastic#43223)
  [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804)
  docs: add tip on agent config in a dt (elastic#43301)
  [ML] Adding bucket span estimator to new wizards (elastic#43288)
  disable flaky tests (elastic#43017)
  Fix percy target branch for PRs (elastic#43160)
  [ML] Adding post create job options (elastic#43205)
  Restore discover histogram selection triggering fetch (elastic#43097)
  Per panel time range (elastic#43153)
  [Infra UI] Add APM to Metadata Endpoint (elastic#42197)
  Sentence case copy changes (elastic#43215)
  ...
timroes pushed a commit that referenced this pull request Aug 16, 2019
…43287)

* Restore discover histogram selection triggering fetch (#43097)

* Listen to timefilter fetch event to start fetching

* Improve functional test to catch error

* Adjust functional test for 7.3

* Skip functional test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.3.1 v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting a period in the discover histogram does not result in a refresh.
4 participants