Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Add contentManagement dependency to Observability and Security solution plugins #165225

Merged
merged 11 commits into from
Sep 4, 2023

Conversation

js-jankisalvi
Copy link
Contributor

@js-jankisalvi js-jankisalvi commented Aug 30, 2023

Summary

Fixes #164736

This PR updates

This change is necessary as cases plugin uses contentManagement to add lens embeddable to markdown editor

Security Solution:

Sec_lens.mov

Observability:

Screen.Recording.2023-08-30.at.13.59.32.mov

@js-jankisalvi js-jankisalvi added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.10.0 v8.11.0 labels Aug 30, 2023
@js-jankisalvi js-jankisalvi requested review from a team as code owners August 30, 2023 12:04
@js-jankisalvi js-jankisalvi self-assigned this Aug 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@js-jankisalvi js-jankisalvi requested a review from a team August 30, 2023 12:05
@js-jankisalvi js-jankisalvi changed the title [Cases] add contentManagement dependency to Observability and Security solution [Cases] Add contentManagement dependency to Observability and Security solution plugins Aug 30, 2023
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the Lens integration in the markdown editor and it works as expected in all solutions (Security, Observability, and Stack).

@cnasikas cnasikas added the bug Fixes for quality problems that affect the customer experience label Aug 30, 2023
@mgiota mgiota self-requested a review August 30, 2023 20:24
@mgiota
Copy link
Contributor

mgiota commented Aug 30, 2023

LGTM! I tested the Lens integration in the markdown editor in Obervability and it works as expected.

Screenshot 2023-08-30 at 22 23 34

@cnasikas
Copy link
Member

@elasticmachine merge upstream

@cnasikas cnasikas enabled auto-merge (squash) August 31, 2023 16:59
@cnasikas
Copy link
Member

cnasikas commented Sep 1, 2023

@elasticmachine merge upstream

@cnasikas cnasikas added the ci:skip-cypress-osquery Skips osquery cypress checks label Sep 1, 2023
@js-jankisalvi
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 4, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Observability Tests / serverless common API scripted fields disabled "before all" hook for "scripted fields are ignored when disabled"
  • [job] [logs] Serverless Observability Tests / serverless common UI API keys should create and delete API keys correctly
  • [job] [logs] Serverless Observability Examples Tests / serverless examples UI Partial Results Example "before all" hook for "should trace mouse events"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 532 533 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 61.8KB 61.8KB -10.0B
Unknown metric groups

API count

id before after diff
observability 541 542 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @js-jankisalvi

@cnasikas cnasikas merged commit a2e841e into elastic:main Sep 4, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.10 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 165225

Questions ?

Please refer to the Backport tool documentation

@js-jankisalvi
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

js-jankisalvi added a commit to js-jankisalvi/kibana that referenced this pull request Sep 4, 2023
…y solution plugins (elastic#165225)

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit a2e841e)

# Conflicts:
#	x-pack/plugins/observability/public/plugin.mock.tsx
#	x-pack/plugins/observability/tsconfig.json
#	x-pack/plugins/security_solution/tsconfig.json
sphilipse pushed a commit to sphilipse/kibana that referenced this pull request Sep 4, 2023
js-jankisalvi added a commit that referenced this pull request Sep 4, 2023
…Security solution plugins (#165225) (#165574)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Cases] Add contentManagement dependency to Observability and
Security solution plugins
(#165225)](#165225)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-04T08:10:14Z","message":"[Cases]
Add contentManagement dependency to Observability and Security solution
plugins (#165225)\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"a2e841e6e45fb7605a60b4a6e85a124cd86ba487","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Cases","ci:skip-cypress-osquery","v8.10.0","v8.11.0"],"number":165225,"url":"https://github.com/elastic/kibana/pull/165225","mergeCommit":{"message":"[Cases]
Add contentManagement dependency to Observability and Security solution
plugins (#165225)\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"a2e841e6e45fb7605a60b4a6e85a124cd86ba487"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165225","number":165225,"mergeCommit":{"message":"[Cases]
Add contentManagement dependency to Observability and Security solution
plugins (#165225)\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"a2e841e6e45fb7605a60b4a6e85a124cd86ba487"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
@js-jankisalvi js-jankisalvi deleted the fix-lens-in-markdown-serverless branch October 6, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience ci:skip-cypress-osquery Skips osquery cypress checks Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cases] Attaching Lens Visualization to case via markdown editor is broken
7 participants