-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Add contentManagement dependency to Observability and Security solution plugins #165225
[Cases] Add contentManagement dependency to Observability and Security solution plugins #165225
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the Lens integration in the markdown editor and it works as expected in all solutions (Security, Observability, and Stack).
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…y solution plugins (elastic#165225) Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a2e841e) # Conflicts: # x-pack/plugins/observability/public/plugin.mock.tsx # x-pack/plugins/observability/tsconfig.json # x-pack/plugins/security_solution/tsconfig.json
…y solution plugins (elastic#165225) Co-authored-by: kibanamachine <[email protected]>
…Security solution plugins (#165225) (#165574) # Backport This will backport the following commits from `main` to `8.10`: - [[Cases] Add contentManagement dependency to Observability and Security solution plugins (#165225)](#165225) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Janki Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-04T08:10:14Z","message":"[Cases] Add contentManagement dependency to Observability and Security solution plugins (#165225)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"a2e841e6e45fb7605a60b4a6e85a124cd86ba487","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Cases","ci:skip-cypress-osquery","v8.10.0","v8.11.0"],"number":165225,"url":"https://github.com/elastic/kibana/pull/165225","mergeCommit":{"message":"[Cases] Add contentManagement dependency to Observability and Security solution plugins (#165225)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"a2e841e6e45fb7605a60b4a6e85a124cd86ba487"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165225","number":165225,"mergeCommit":{"message":"[Cases] Add contentManagement dependency to Observability and Security solution plugins (#165225)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"a2e841e6e45fb7605a60b4a6e85a124cd86ba487"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Fixes #164736
This PR updates
contentManagement
instead ofsavedObjectsManagement
as per MakeSavedObjectFinder
backward compatible #162904contentManagement
to observability pluginThis change is necessary as cases plugin uses contentManagement to add lens embeddable to markdown editor
Security Solution:
Sec_lens.mov
Observability:
Screen.Recording.2023-08-30.at.13.59.32.mov