Skip to content

Commit

Permalink
[8.10] [Cases] Add contentManagement dependency to Observability and …
Browse files Browse the repository at this point in the history
…Security solution plugins (#165225) (#165574)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Cases] Add contentManagement dependency to Observability and
Security solution plugins
(#165225)](#165225)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-04T08:10:14Z","message":"[Cases]
Add contentManagement dependency to Observability and Security solution
plugins (#165225)\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"a2e841e6e45fb7605a60b4a6e85a124cd86ba487","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Cases","ci:skip-cypress-osquery","v8.10.0","v8.11.0"],"number":165225,"url":"https://github.com/elastic/kibana/pull/165225","mergeCommit":{"message":"[Cases]
Add contentManagement dependency to Observability and Security solution
plugins (#165225)\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"a2e841e6e45fb7605a60b4a6e85a124cd86ba487"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165225","number":165225,"mergeCommit":{"message":"[Cases]
Add contentManagement dependency to Observability and Security solution
plugins (#165225)\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"a2e841e6e45fb7605a60b4a6e85a124cd86ba487"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
  • Loading branch information
js-jankisalvi and kibanamachine authored Sep 4, 2023
1 parent 706cf86 commit 403d948
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 7 deletions.
1 change: 1 addition & 0 deletions x-pack/plugins/observability/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"alerting",
"cases",
"charts",
"contentManagement",
"data",
"dataViews",
"dataViewEditor",
Expand Down
2 changes: 2 additions & 0 deletions x-pack/plugins/observability/public/plugin.mock.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/
import React from 'react';
import { mockCasesContract } from '@kbn/cases-plugin/public/mocks';
import { contentManagementMock } from '@kbn/content-management-plugin/public/mocks';
import { timefilterServiceMock } from '@kbn/data-plugin/public/query/timefilter/timefilter_service.mock';

const triggersActionsUiStartMock = {
Expand Down Expand Up @@ -110,6 +111,7 @@ export const observabilityPublicPluginsStartMock = {
createStart() {
return {
cases: mockCasesContract(),
contentManagement: contentManagementMock.createStartContract(),
triggersActionsUi: triggersActionsUiStartMock.createStart(),
data: data.createStart(),
dataViews: dataViews.createStart(),
Expand Down
2 changes: 2 additions & 0 deletions x-pack/plugins/observability/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import {
TriggersAndActionsUIPublicPluginSetup,
TriggersAndActionsUIPublicPluginStart,
} from '@kbn/triggers-actions-ui-plugin/public';
import type { ContentManagementPublicStart } from '@kbn/content-management-plugin/public';

import { UsageCollectionSetup } from '@kbn/usage-collection-plugin/public';
import {
Expand Down Expand Up @@ -115,6 +116,7 @@ export interface ObservabilityPublicPluginsStart {
actionTypeRegistry: ActionTypeRegistryContract;
cases: CasesUiStart;
charts: ChartsPluginStart;
contentManagement: ContentManagementPublicStart;
data: DataPublicPluginStart;
dataViews: DataViewsPublicPluginStart;
dataViewEditor: DataViewEditorStart;
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/observability/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@
"@kbn/actions-plugin",
"@kbn/core-capabilities-common",
"@kbn/deeplinks-analytics",
"@kbn/observability-ai-assistant-plugin"
"@kbn/observability-ai-assistant-plugin",
"@kbn/content-management-plugin"
],
"exclude": [
"target/**/*"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"cloud",
"cloudDefend",
"cloudSecurityPosture",
"contentManagement",
"dashboard",
"data",
"dataViews",
Expand Down Expand Up @@ -45,7 +46,6 @@
"files",
"controls",
"dataViewEditor",
"savedObjectsManagement",
"stackConnectors",
"discover",
"notifications"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
securityLayout: {
getPluginWrapper: () => SecuritySolutionTemplateWrapper,
},
savedObjectsManagement: startPluginsDeps.savedObjectsManagement,
contentManagement: startPluginsDeps.contentManagement,
telemetry: this.telemetry.start(),
discoverFilterManager: filterManager,
customDataService,
Expand Down
6 changes: 3 additions & 3 deletions x-pack/plugins/security_solution/public/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import type { ThreatIntelligencePluginStart } from '@kbn/threat-intelligence-plu
import type { CloudExperimentsPluginStart } from '@kbn/cloud-experiments-plugin/common';
import type { GuidedOnboardingPluginStart } from '@kbn/guided-onboarding-plugin/public';
import type { DataViewsServicePublic } from '@kbn/data-views-plugin/public';
import type { SavedObjectsManagementPluginStart } from '@kbn/saved-objects-management-plugin/public';
import type { ContentManagementPublicStart } from '@kbn/content-management-plugin/public';

import type { RouteProps } from 'react-router-dom';
import type { DiscoverStart } from '@kbn/discover-plugin/public';
Expand Down Expand Up @@ -133,7 +133,7 @@ export interface StartPlugins {
}

export interface StartPluginsDependencies extends StartPlugins {
savedObjectsManagement: SavedObjectsManagementPluginStart;
contentManagement: ContentManagementPublicStart;
savedObjectsTaggingOss: SavedObjectTaggingOssPluginStart;
}

Expand All @@ -160,7 +160,7 @@ export type StartServices = CoreStart &
securityLayout: {
getPluginWrapper: () => typeof SecuritySolutionTemplateWrapper;
};
savedObjectsManagement: SavedObjectsManagementPluginStart;
contentManagement: ContentManagementPublicStart;
telemetry: TelemetryClientStart;
discoverFilterManager: FilterManager;
customDataService: DataPublicPluginStart;
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@
"@kbn/expandable-flyout",
"@kbn/securitysolution-grouping",
"@kbn/securitysolution-data-table",
"@kbn/saved-objects-management-plugin",
"@kbn/core-analytics-server",
"@kbn/analytics-client",
"@kbn/security-solution-side-nav",
Expand All @@ -169,5 +168,6 @@
"@kbn/core-logging-server-mocks",
"@kbn/core-lifecycle-browser",
"@kbn/handlebars",
"@kbn/content-management-plugin"
]
}

0 comments on commit 403d948

Please sign in to comment.