Skip to content

Commit

Permalink
[Cases] Add contentManagement dependency to Observability and Securit…
Browse files Browse the repository at this point in the history
…y solution plugins (#165225)

Co-authored-by: kibanamachine <[email protected]>
  • Loading branch information
js-jankisalvi and kibanamachine authored Sep 4, 2023
1 parent d06af6f commit a2e841e
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 8 deletions.
1 change: 1 addition & 0 deletions x-pack/plugins/observability/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"alerting",
"cases",
"charts",
"contentManagement",
"data",
"dataViews",
"dataViewEditor",
Expand Down
2 changes: 2 additions & 0 deletions x-pack/plugins/observability/public/plugin.mock.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import React from 'react';
import { mockCasesContract } from '@kbn/cases-plugin/public/mocks';
import { chartPluginMock } from '@kbn/charts-plugin/public/mocks';
import { dataPluginMock } from '@kbn/data-plugin/public/mocks';
import { contentManagementMock } from '@kbn/content-management-plugin/public/mocks';

const triggersActionsUiStartMock = {
createStart() {
Expand Down Expand Up @@ -94,6 +95,7 @@ export const observabilityPublicPluginsStartMock = {
return {
cases: mockCasesContract(),
charts: chartPluginMock.createStartContract(),
contentManagement: contentManagementMock.createStartContract(),
triggersActionsUi: triggersActionsUiStartMock.createStart(),
data: dataPluginMock.createStartContract(),
dataViews: dataViews.createStart(),
Expand Down
2 changes: 2 additions & 0 deletions x-pack/plugins/observability/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import {
TriggersAndActionsUIPublicPluginSetup,
TriggersAndActionsUIPublicPluginStart,
} from '@kbn/triggers-actions-ui-plugin/public';
import type { ContentManagementPublicStart } from '@kbn/content-management-plugin/public';

import { UsageCollectionSetup } from '@kbn/usage-collection-plugin/public';
import {
Expand Down Expand Up @@ -115,6 +116,7 @@ export interface ObservabilityPublicPluginsStart {
actionTypeRegistry: ActionTypeRegistryContract;
cases: CasesUiStart;
charts: ChartsPluginStart;
contentManagement: ContentManagementPublicStart;
data: DataPublicPluginStart;
dataViews: DataViewsPublicPluginStart;
dataViewEditor: DataViewEditorStart;
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/observability/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@
"@kbn/core-capabilities-common",
"@kbn/deeplinks-analytics",
"@kbn/observability-ai-assistant-plugin",
"@kbn/osquery-plugin"
"@kbn/osquery-plugin",
"@kbn/content-management-plugin"
],
"exclude": [
"target/**/*"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"cloud",
"cloudDefend",
"cloudSecurityPosture",
"contentManagement",
"dashboard",
"data",
"dataViews",
Expand Down Expand Up @@ -46,7 +47,6 @@
"files",
"controls",
"dataViewEditor",
"savedObjectsManagement",
"stackConnectors",
"discover",
"notifications"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
securityLayout: {
getPluginWrapper: () => SecuritySolutionTemplateWrapper,
},
savedObjectsManagement: startPluginsDeps.savedObjectsManagement,
contentManagement: startPluginsDeps.contentManagement,
telemetry: this.telemetry.start(),
customDataService,
topValuesPopover: new TopValuesPopoverService(),
Expand Down
6 changes: 3 additions & 3 deletions x-pack/plugins/security_solution/public/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import type { ThreatIntelligencePluginStart } from '@kbn/threat-intelligence-plu
import type { CloudExperimentsPluginStart } from '@kbn/cloud-experiments-plugin/common';
import type { GuidedOnboardingPluginStart } from '@kbn/guided-onboarding-plugin/public';
import type { DataViewsServicePublic } from '@kbn/data-views-plugin/public';
import type { SavedObjectsManagementPluginStart } from '@kbn/saved-objects-management-plugin/public';
import type { ContentManagementPublicStart } from '@kbn/content-management-plugin/public';

import type { RouteProps } from 'react-router-dom';
import type { DiscoverStart } from '@kbn/discover-plugin/public';
Expand Down Expand Up @@ -133,7 +133,7 @@ export interface StartPlugins {
}

export interface StartPluginsDependencies extends StartPlugins {
savedObjectsManagement: SavedObjectsManagementPluginStart;
contentManagement: ContentManagementPublicStart;
savedObjectsTaggingOss: SavedObjectTaggingOssPluginStart;
}

Expand Down Expand Up @@ -161,7 +161,7 @@ export type StartServices = CoreStart &
securityLayout: {
getPluginWrapper: () => typeof SecuritySolutionTemplateWrapper;
};
savedObjectsManagement: SavedObjectsManagementPluginStart;
contentManagement: ContentManagementPublicStart;
telemetry: TelemetryClientStart;
customDataService: DataPublicPluginStart;
topValuesPopover: TopValuesPopoverService;
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/security_solution/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@
"@kbn/expandable-flyout",
"@kbn/securitysolution-grouping",
"@kbn/securitysolution-data-table",
"@kbn/saved-objects-management-plugin",
"@kbn/core-analytics-server",
"@kbn/analytics-client",
"@kbn/security-solution-side-nav",
Expand All @@ -172,6 +171,7 @@
"@kbn/core-logging-server-mocks",
"@kbn/core-lifecycle-browser",
"@kbn/security-solution-features",
"@kbn/handlebars"
"@kbn/handlebars",
"@kbn/content-management-plugin"
]
}

0 comments on commit a2e841e

Please sign in to comment.