[APM] Fix search bar suggestions #141101
Merged
[APM] Fix search bar suggestions #141101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
force-pushed
the
fix-search-bar
branch
from
4b5f4de to
b0fddbd
Compare
sorenlouv
commented
Sep 20, 2022
| return { | ||
| created: false, | ||
| reason: 'Dataview already exists in current space', | ||
| }; |
There was a problem hiding this comment.
For better debugging the endpoint now returns the reason for not creating the data view
sorenlouv
force-pushed
the
fix-search-bar
branch
from
10487c6 to
42b9a60
Compare
sorenlouv
added
v8.5.0
release_note:fix
Team:APM
|
Pinging @elastic/apm-ui (Team:APM) |
cauemarcondes
approved these changes
Sep 21, 2022
| return { | ||
| created: false, | ||
| reason: | ||
| 'Auto-creation of data views has been disabled via "autoCreateApmDataView" config option', |
There was a problem hiding this comment.
Missing translation here?!
| if (!hasData) { | ||
| return; | ||
| return { created: false, reason: 'No APM data' }; |
sorenlouv
force-pushed
the
fix-search-bar
branch
from
4e860b7 to
d2608c7
Compare
|
Buildkite, test this |
💚 Build Succeeded
Metrics [docs]Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 22, 2022
* main: (33 commits) Fix Next and Previous button on step screenshot carousel. (elastic#141422) [journeys] add a short delay after loading data (elastic#141437) skip failing test suite (elastic#140797) skip failing test suite (elastic#138776) Documents saved objects bulk delete API (elastic#141164) [Response Ops][Alerting] Defining default action params on connector type (elastic#141226) [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213) [APM] Fix search bar suggestions (elastic#141101) close popover on click (elastic#141272) [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276) [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239) [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228) [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288) Shameless copy of the retryTransientEsErrors from fleet (elastic#141246) [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735) Changing triggers actions ui routes to internal (elastic#141149) skip flaky test suit elastic#141356 [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043) [dashboard controls] skip failing test on cloud (elastic#141291) [Synthetics] unskip edit_monitor api integration tests (elastic#141277) ...
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
sorenlouv
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2022
(cherry picked from commit 52e01a3)
kibanamachine
removed
the
backport missing
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2022
(cherry picked from commit 52e01a3) Co-authored-by: Søren Louv-Jansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140964
Related: #136694
In 8.4 this PR changed the search bar in APM to prefer static data view over dynamic data view when producing field suggestions. This surfaced a bug that has affected APM for a lot longer, which means that the static APM data view is only available in the space in which it was initially created (normally the "default" space).
Without a static data view the search bar stops working.
This PR reverts some of the changes introduced in #136694 specifically the reliance on static data view for search bar. It will now only use the dynamic data view which fixes the problem.
This PR also fixes the underlying problem, making the APM data view available across all spaces.