-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[journeys] add a short delay after loading data #141437
Merged
spalger
merged 1 commit into
elastic:main
from
spalger:implement/journeys-delay-after-data-load
Sep 22, 2022
Merged
[journeys] add a short delay after loading data #141437
spalger
merged 1 commit into
elastic:main
from
spalger:implement/journeys-delay-after-data-load
Sep 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
Team label for Operations Team
wg:performance
Work tracked by the performance workgroup
labels
Sep 22, 2022
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
force-pushed
the
implement/journeys-delay-after-data-load
branch
from
September 22, 2022 13:57
e659b9e
to
9119236
Compare
spalger
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Sep 22, 2022
suchcodemuchwow
approved these changes
Sep 22, 2022
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.6.0
backport:skip
This commit does not require backporting
labels
Sep 22, 2022
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 22, 2022
* main: (33 commits) Fix Next and Previous button on step screenshot carousel. (elastic#141422) [journeys] add a short delay after loading data (elastic#141437) skip failing test suite (elastic#140797) skip failing test suite (elastic#138776) Documents saved objects bulk delete API (elastic#141164) [Response Ops][Alerting] Defining default action params on connector type (elastic#141226) [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213) [APM] Fix search bar suggestions (elastic#141101) close popover on click (elastic#141272) [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276) [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239) [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228) [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288) Shameless copy of the retryTransientEsErrors from fleet (elastic#141246) [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735) Changing triggers actions ui routes to internal (elastic#141149) skip flaky test suit elastic#141356 [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043) [dashboard controls] skip failing test on cloud (elastic#141291) [Synthetics] unskip edit_monitor api integration tests (elastic#141277) ...
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
reverted
Team:Operations
Team label for Operations Team
v8.6.0
wg:performance
Work tracked by the performance workgroup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our journeys saw a marked change in performance this morning after #140680 was merged. This PR shouldn't have made any impact on the performance, so we're trying to find the minor differences and understand what might have caused this. In several metrics we're seeing "time to data" stats increase, and one thing that might be causing this the the fact that we used to load esArchives and kbnArchives during service initialization, but now we're loading these archives in a
before()
hook.I think this might be why queries run a little slower, maybe we should wait a little bit after indexing the data?
In order to try and reproduce this situation I'd like to add a 10 second delay after loading esArchives and kbnArchives and see if that impacts times at all.