Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slo): Shameless copy of the retryTransientEsErrors from fleet #141246

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

kdelemme
Copy link
Contributor

📝 Summary

Resolves #141082

Copied 🙈 the transient error retry service from Fleet to our plugin, and integrate it into our transform manager service.

💬 I've added only one retry test scenario using the transform service because each test takes 1s, and the retry service is already tested thoroughly.

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0 labels Sep 21, 2022
@kdelemme kdelemme self-assigned this Sep 21, 2022
@kdelemme kdelemme marked this pull request as ready for review September 21, 2022 14:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kdelemme kdelemme requested a review from a team September 21, 2022 14:56
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying was done perfectly 😄 (I just check the code, not sure if I need to test something locally)

Did you face an issue that you find this solution for it or is it a preventative measure?

@kdelemme
Copy link
Contributor Author

Did you face an issue that you find this solution for it or is it a preventative measure?

No I haven't got any issue like this, but I agreed with @fkanout when he suggested to add this.

@kdelemme kdelemme merged commit 51e2587 into elastic:main Sep 22, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 22, 2022
@kdelemme kdelemme deleted the chore/141082-retry-transient-errors branch September 22, 2022 13:08
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 22, 2022
* main: (33 commits)
  Fix Next and Previous button on step screenshot carousel. (elastic#141422)
  [journeys] add a short delay after loading data (elastic#141437)
  skip failing test suite (elastic#140797)
  skip failing test suite (elastic#138776)
  Documents saved objects bulk delete API (elastic#141164)
  [Response Ops][Alerting] Defining default action params on connector type (elastic#141226)
  [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213)
  [APM] Fix search bar suggestions (elastic#141101)
  close popover on click (elastic#141272)
  [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276)
  [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239)
  [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228)
  [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288)
  Shameless copy of the retryTransientEsErrors from fleet (elastic#141246)
  [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735)
  Changing triggers actions ui routes to internal (elastic#141149)
  skip flaky test suit elastic#141356
  [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043)
  [dashboard controls] skip failing test on cloud (elastic#141291)
  [Synthetics] unskip edit_monitor api integration tests (elastic#141277)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Actionable Observability] Handle transient errors with esClient
5 participants