Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix APM search bar (8.4 backport only) #141738

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Sep 26, 2022

Related issue: #140964
Manual backport of: #141101

This fixes a problem with the search bar in APM, that caused suggestions to not show up in non-default spaces. This does not fix the problem where navigating to Discover from APM in a non-default space breaks. This issue is only fixed in 8.5+ (#141101)

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@sorenlouv sorenlouv merged commit 9844e25 into elastic:8.4 Sep 27, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB -352.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 28.5KB 28.3KB -141.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv deleted the fix-search-bar-8.4-backport branch September 27, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:APM All issues that need APM UI Team support v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants