Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited the search session management page font size #131291

Merged
merged 4 commits into from May 6, 2022
Merged

Edited the search session management page font size #131291

merged 4 commits into from May 6, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2022

Summary

This is a PR for issue #129714

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ghost ghost self-requested a review as a code owner May 1, 2022 04:32
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Dosant
Copy link
Contributor

Dosant commented May 2, 2022

@elasticmachine, merge upstream

@Dosant
Copy link
Contributor

Dosant commented May 2, 2022

buildkite, test this

@Dosant
Copy link
Contributor

Dosant commented May 2, 2022

@najmiehsa, thank you!

There is a formatting issue https://buildkite.com/elastic/kibana-pull-request/builds/41736#84b58711-81b9-4520-8a04-1a12e0dde488 atm:

ebg [casing] "src/plugins/data/public/search/session/sessions_mgmt/components/table/table.tsx" uses valid casing
--
  | debg [eslint] linting "src/plugins/data/public/search/session/sessions_mgmt/components/table/table.tsx"
  | ERROR
  | /opt/local-ssd/buildkite/builds/kb-c2-8-c5ccee6f799fad80/elastic/kibana-pull-request/kibana/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.tsx
  | 74:18  error  Delete `·`  prettier/prettier
  |  
  | ✖ 1 problem (1 error, 0 warnings)
  | 1 error and 0 warnings potentially fixable with the `--fix` option.
  |  
  | ERROR [eslint] errors

@ghost
Copy link
Author

ghost commented May 2, 2022

@Dosant Hi, Thank you for the feedback. I know I should run this node scripts/precommit_hook --fix in my local repository.
Once I run the command, I get Error: Cannot find module '@kbn/optimizer' at the moment.
I try to fix this.

@Dosant
Copy link
Contributor

Dosant commented May 2, 2022

Once I run the command, I get Error: Cannot find module '@kbn/optimizer' at the moment.

have you run yarn kbn bootstrap ? have you been able to start Kibana locally?

This guide should help:
https://www.elastic.co/guide/en/kibana/master/development-getting-started.html

@Dosant
Copy link
Contributor

Dosant commented May 2, 2022

buildkite, test this

@Dosant
Copy link
Contributor

Dosant commented May 2, 2022

Actually, in this commit CI automatically fixed prettier: 472607a

@ghost
Copy link
Author

ghost commented May 2, 2022

Once I run the command, I get Error: Cannot find module '@kbn/optimizer' at the moment.

have you run yarn kbn bootstrap ? have you been able to start Kibana locally?

This guide should help: https://www.elastic.co/guide/en/kibana/master/development-getting-started.html

Thank you.

@Dosant
Copy link
Contributor

Dosant commented May 2, 2022

I took a look at the fix,

I think we should instead change default size from m -> s here:

And that should be it

@ghost
Copy link
Author

ghost commented May 2, 2022

@Dosant I think it is fixed now.

@Dosant
Copy link
Contributor

Dosant commented May 4, 2022

@Dosant I think it is fixed now.

@najmiehsa, thanks!
I think we don't need changes in src/plugins/data/public/search/session/sessions_mgmt/components/table/table.tsx anymore because this is handled inside a component now.
Could you revert changes in that file, please?

@ghost
Copy link
Author

ghost commented May 4, 2022

Yes, Sure.

@ghost
Copy link
Author

ghost commented May 4, 2022

@Dosant I think it is fixed now.

@najmiehsa, thanks! I think we don't need changes in src/plugins/data/public/search/session/sessions_mgmt/components/table/table.tsx anymore because this is handled inside a component now. Could you revert changes in that file, please?

It should be good now.

@Dosant
Copy link
Contributor

Dosant commented May 6, 2022

@elasticmachine merge upstream

@Dosant
Copy link
Contributor

Dosant commented May 6, 2022

buildkite, test this

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #41774 failed 472607a3533458573ae6fb80194ee9f3d9accd62
  • 💔 Build #41736 failed 96129048fbd188fab0d94fb8fa60626fbdafb421

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant added Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@Dosant
Copy link
Contributor

Dosant commented May 6, 2022

@elasticmachine run elasticsearch-ci/docs

@Dosant Dosant merged commit 984e212 into elastic:main May 6, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 6, 2022
@Dosant
Copy link
Contributor

Dosant commented May 6, 2022

@najmiehsa, Thank you for the contribution 🚀

@ghost ghost deleted the size-ed02 branch May 6, 2022 15:29
@ghost
Copy link
Author

ghost commented May 6, 2022

Thank you.

jloleysens added a commit to jloleysens/kibana that referenced this pull request May 9, 2022
…hromium-to-print-pdf-part-1

* 'main' of github.com:elastic/kibana: (59 commits)
  [Cloud Posture] Enabled findings group by feature (elastic#131780)
  [EBT] Fix `userId` generation (elastic#131701)
  [RAM] Add shareable rule tag filter (elastic#130710)
  Optimize package installation performance, phase 2 (elastic#131627)
  [Screenshotting] instrument for benchmark tests using new EventLogger class (elastic#130356)
  [Connector] Adding internal route for requesting ad-hoc ServiceNow access token (elastic#131171)
  [ci] bump kibana-buildkite-library (elastic#131754)
  [Synthetics] UI clean up (elastic#131598)
  [RsponseOps] Fix flaky rules list test (elastic#131567)
  [Cases] Add severity field to create case (elastic#131626)
  [Discover] Monospace font in Document Explorer (elastic#131513)
  Sessions tab improvements (elastic#131583)
  Add cloud icon "ess-icon" at the end of the config keys in "alerting" documentation (elastic#131735)
  [DOCS] Updates deprecation text for legacy APIs (elastic#131741)
  [ci] break out skip patterns so they can change without triggering CI (elastic#131726)
  Adjust search session management page font size (elastic#131291)
  [Unified search] Fix uptime css problem (elastic#131730)
  [Actionable Observability] Link to filtered rules page (elastic#131629)
  Add openAPI specifications for cases endpoint (elastic#131275)
  Display rule API key owner to users who can manage API keys (elastic#131662)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/server/formats/pdf/index.ts
#	x-pack/plugins/screenshotting/server/screenshots/observable.ts
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants