[RsponseOps] Fix flaky rules list test #131567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaweiWu
added
release_note:skip
spalger
reviewed
May 4, 2022
| await assertRulesLength(1); | ||
|
|
||
| // Select disabled | ||
| await testSubjects.click('ruleStatusFilterOption-enabled'); | ||
| await testSubjects.click('ruleStatusFilterOption-disabled'); | ||
| await new Promise((res) => setTimeout(res, 1000)); |
There was a problem hiding this comment.
Is there anything on the page you can check for before asserting the rules length? Using a sleep like this is only going to work in very specific timing conditions which change constantly, and extending the sleep to work in more conditions just extends the length of CI unnecessarily.
If there's a loading message in the UI that tells users the list is updating, then we should use the same indication to tell the tests that the list is still loading, like:
await testSubjects.waitForDeleted('ruleTableLoading');
await assertRulesLength(1);
There was a problem hiding this comment.
Yup, checkout my wait functions in this test
|
passing flaky test runner build: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/558 |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
spalger
suggested changes
May 5, 2022
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts_list.ts
Outdated
Show resolved
Hide resolved
|
another flaky test build: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/561 |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 9, 2022
…hromium-to-print-pdf-part-1 * 'main' of github.com:elastic/kibana: (59 commits) [Cloud Posture] Enabled findings group by feature (elastic#131780) [EBT] Fix `userId` generation (elastic#131701) [RAM] Add shareable rule tag filter (elastic#130710) Optimize package installation performance, phase 2 (elastic#131627) [Screenshotting] instrument for benchmark tests using new EventLogger class (elastic#130356) [Connector] Adding internal route for requesting ad-hoc ServiceNow access token (elastic#131171) [ci] bump kibana-buildkite-library (elastic#131754) [Synthetics] UI clean up (elastic#131598) [RsponseOps] Fix flaky rules list test (elastic#131567) [Cases] Add severity field to create case (elastic#131626) [Discover] Monospace font in Document Explorer (elastic#131513) Sessions tab improvements (elastic#131583) Add cloud icon "ess-icon" at the end of the config keys in "alerting" documentation (elastic#131735) [DOCS] Updates deprecation text for legacy APIs (elastic#131741) [ci] break out skip patterns so they can change without triggering CI (elastic#131726) Adjust search session management page font size (elastic#131291) [Unified search] Fix uptime css problem (elastic#131730) [Actionable Observability] Link to filtered rules page (elastic#131629) Add openAPI specifications for cases endpoint (elastic#131275) Display rule API key owner to users who can manage API keys (elastic#131662) ... # Conflicts: # x-pack/plugins/screenshotting/server/formats/pdf/index.ts # x-pack/plugins/screenshotting/server/screenshots/observable.ts
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
* Add delay to make test less flaky * Addressed comments * Addressed comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #131535
Waits for the rules list to re-render before assertions