Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RsponseOps] Fix flaky rules list test #131567

Merged
merged 3 commits into from
May 6, 2022
Merged

[RsponseOps] Fix flaky rules list test #131567

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22b99a3
Add delay to make test less flaky
JiaweiWu May 4, 2022
f471f5c
Addressed comments
JiaweiWu May 4, 2022
ba58a6e
Addressed comments
JiaweiWu May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts_list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('rulesTab');
}

// FLAKY: https://github.com/elastic/kibana/issues/131535
describe.skip('rules list', function () {
describe('rules list', function () {
before(async () => {
await pageObjects.common.navigateToApp('triggersActions');
await testSubjects.click('rulesTab');
Expand Down Expand Up @@ -640,24 +639,34 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
// Select enabled
await testSubjects.click('ruleStatusFilterButton');
await testSubjects.click('ruleStatusFilterOption-enabled');
await find.waitForDeletedByCssSelector('.euiBasicTable-loading');

await assertRulesLength(1);

// Select disabled
await testSubjects.click('ruleStatusFilterOption-enabled');
await testSubjects.click('ruleStatusFilterOption-disabled');
await find.waitForDeletedByCssSelector('.euiBasicTable-loading');

await assertRulesLength(1);

// Select snoozed
await testSubjects.click('ruleStatusFilterOption-disabled');
await testSubjects.click('ruleStatusFilterOption-snoozed');
await find.waitForDeletedByCssSelector('.euiBasicTable-loading');

await assertRulesLength(1);

// Select disabled and snoozed
await testSubjects.click('ruleStatusFilterOption-disabled');
await find.waitForDeletedByCssSelector('.euiBasicTable-loading');

await assertRulesLength(2);

// Select all 3
await testSubjects.click('ruleStatusFilterOption-enabled');
await find.waitForDeletedByCssSelector('.euiBasicTable-loading');

await assertRulesLength(3);
});
});
Expand Down