Skip to content

Commit

Permalink
Disable time slider control (#130978)
Browse files Browse the repository at this point in the history
Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
Corey Robertson and kibanamachine authored May 2, 2022
1 parent 15ac520 commit 0745196
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
7 changes: 6 additions & 1 deletion src/plugins/controls/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,14 @@ import {
CONTROL_GROUP_TYPE,
OPTIONS_LIST_CONTROL,
RANGE_SLIDER_CONTROL,
TIME_SLIDER_CONTROL,
// TIME_SLIDER_CONTROL,
} from '.';
/*
import {
TimesliderEmbeddableFactory,
TimeSliderControlEmbeddableInput,
} from './control_types/time_slider';
*/
import { controlsService } from './services/kibana/controls';

export class ControlsPlugin
Expand Down Expand Up @@ -104,6 +106,7 @@ export class ControlsPlugin
registerControlType(rangeSliderFactory);

// Time Slider Control Factory Setup
/* Temporary disabling Time Slider
const timeSliderFactoryDef = new TimesliderEmbeddableFactory();
const timeSliderFactory = embeddable.registerEmbeddableFactory(
TIME_SLIDER_CONTROL,
Expand All @@ -113,8 +116,10 @@ export class ControlsPlugin
timeSliderFactoryDef,
timeSliderFactory
);
registerControlType(timeSliderFactory);
*/
});

return {
Expand Down
5 changes: 3 additions & 2 deletions src/plugins/controls/server/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { PluginSetup as UnifiedSearchSetup } from '@kbn/unified-search-plugin/se
import { setupOptionsListSuggestionsRoute } from './control_types/options_list/options_list_suggestions_route';
import { controlGroupContainerPersistableStateServiceFactory } from './control_group/control_group_container_factory';
import { optionsListPersistableStateServiceFactory } from './control_types/options_list/options_list_embeddable_factory';
import { timeSliderPersistableStateServiceFactory } from './control_types/time_slider/time_slider_embeddable_factory';
// import { timeSliderPersistableStateServiceFactory } from './control_types/time_slider/time_slider_embeddable_factory';

interface SetupDeps {
embeddable: EmbeddableSetup;
Expand All @@ -25,7 +25,8 @@ interface SetupDeps {
export class ControlsPlugin implements Plugin<object, object, SetupDeps> {
public setup(core: CoreSetup, { embeddable, unifiedSearch }: SetupDeps) {
embeddable.registerEmbeddableFactory(optionsListPersistableStateServiceFactory());
embeddable.registerEmbeddableFactory(timeSliderPersistableStateServiceFactory());
// Temporary disabling Time Slider
// embeddable.registerEmbeddableFactory(timeSliderPersistableStateServiceFactory());

embeddable.registerEmbeddableFactory(
controlGroupContainerPersistableStateServiceFactory(embeddable)
Expand Down

0 comments on commit 0745196

Please sign in to comment.