Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search session management page font size #129714

Closed
vadimkibana opened this issue Apr 7, 2022 · 6 comments
Closed

Search session management page font size #129714

vadimkibana opened this issue Apr 7, 2022 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Sessions good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@vadimkibana
Copy link
Contributor

The font size in search session management table is unexpectedly too large. The table uses 16px font size:

image

Whereas all other places in Kibana, to best of my knowledge, use smaller font size.

Saved objects:

image

Index management:

image

Spaces:

image

@vadimkibana vadimkibana added the bug Fixes for quality problems that affect the customer experience label Apr 7, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 7, 2022
@vadimkibana vadimkibana added Team:AppServicesSv Feature:Search Sessions and removed needs-team Issues missing a team label labels Apr 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@vadimkibana vadimkibana added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Apr 7, 2022
@Dosant Dosant added the good first issue low hanging fruit label Apr 7, 2022
@exalate-issue-sync exalate-issue-sync bot added the loe:small Small Level of Effort label Apr 19, 2022
@ghost
Copy link

ghost commented Apr 20, 2022

@Dosant Can I get the requirements for this issue? I want to work on it.

@Dosant
Copy link
Contributor

Dosant commented Apr 20, 2022

Hi @najmiehsa,
This is quite vague, but there is really nothing more to this issue:
The requirement is to align the search-sessions table look with other management tables we have (saved objects table or index management as seen on screenshots in the description). The problem is that search-session has larger font than other tables.

I would compare the implementation of these different tables and then fixed the search-sessions table to follow the same component structure as other tables.

@ghost
Copy link

ghost commented Apr 22, 2022

Thank you @Dosant.
Can I get references for the files that need to be changed?

@Dosant
Copy link
Contributor

Dosant commented Apr 25, 2022

Here is the code for the table in question:

@Dosant
Copy link
Contributor

Dosant commented May 6, 2022

fixed in #131291

@Dosant Dosant closed this as completed May 6, 2022
@exalate-issue-sync exalate-issue-sync bot reopened this May 20, 2022
@Dosant Dosant closed this as completed May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Sessions good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

3 participants