Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited the search session management page font size #131047

Closed
wants to merge 4 commits into from
Closed

Edited the search session management page font size #131047

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2022

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.
This a PR for issue #129714

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ghost ghost self-requested a review as a code owner April 27, 2022 10:38
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Dosant Dosant self-requested a review April 28, 2022 09:31
@Dosant
Copy link
Contributor

Dosant commented Apr 28, 2022

buildkite, test this

@kibana-ci
Copy link
Collaborator

kibana-ci commented Apr 28, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataEnhanced 45.4KB 45.4KB +7.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant
Copy link
Contributor

Dosant commented Apr 29, 2022

Hi @najmiehsa,
There is a conflict with merging in main,
The problem is that x-pack/plugins/data_enhanced/public/search/sessions_mgmt/components/table/table.tsx was moved to src/plugins/data/public/search/* and the conflict needs to be resolved manually 🙏

@ghost
Copy link
Author

ghost commented Apr 30, 2022

@Dosant Hi,
I first removed the table.tsx from this address x-pack/plugins/data_enhanced/public/search/sessions_mgmt/components/table/table.tsx and added to the src/plugins/data/public/search/*

Then I tried to commit and push my changes. However, once I tried to push I encountered this message " update was rejected because the remote contained changes you don't have"

after this, I tied to sync my fork and I encountered this one "committing is not possible because you have unmerged files"

How can I resolve the merge conflict?

@ghost ghost closed this May 1, 2022
@ghost ghost deleted the size-ed branch May 3, 2022 16:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants