Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Update Fleet TA and HIE cards to use exception list summary API #123900

Merged

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Jan 27, 2022

Summary

Updates fleet host isolation and trusted app cards to use the summary API.

Leftover from /pull/123476
See elastic/kibana/pull/123476/comments

Checklist

Delete any items that are not applicable to this PR.

@ashokaditya ashokaditya self-assigned this Jan 27, 2022
@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.1.0 labels Jan 27, 2022
@ashokaditya ashokaditya force-pushed the task/olm-update_fleet_ta_hie_cards-2513 branch from e88fa6a to af83384 Compare January 27, 2022 13:05
@ashokaditya ashokaditya marked this pull request as ready for review January 27, 2022 13:05
@ashokaditya ashokaditya requested a review from a team as a code owner January 27, 2022 13:05
@ashokaditya ashokaditya requested a review from joeypoon January 27, 2022 13:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@ashokaditya ashokaditya force-pushed the task/olm-update_fleet_ta_hie_cards-2513 branch from f380265 to 39e4ba3 Compare January 27, 2022 15:58
@ashokaditya ashokaditya force-pushed the task/olm-update_fleet_ta_hie_cards-2513 branch from 39e4ba3 to f4ae1b4 Compare January 27, 2022 16:03
Copy link
Contributor

@dasansol92 dasansol92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for applying the suggested changes!

review changes
@ashokaditya ashokaditya force-pushed the task/olm-update_fleet_ta_hie_cards-2513 branch from f4ae1b4 to 609e985 Compare January 27, 2022 16:53
@ashokaditya
Copy link
Member Author

@elasticmachine merge upstream

@ashokaditya ashokaditya enabled auto-merge (squash) January 28, 2022 06:18
@ashokaditya ashokaditya disabled auto-merge January 28, 2022 06:18
@ashokaditya ashokaditya enabled auto-merge (squash) January 28, 2022 06:28
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB -1.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit f697ffe into elastic:main Jan 28, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 28, 2022
@ashokaditya ashokaditya deleted the task/olm-update_fleet_ta_hie_cards-2513 branch January 28, 2022 08:21
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 28, 2022
…fix-potential-race-condition-when-screenshotting

* 'main' of github.com:elastic/kibana: (75 commits)
  [Reporting] Logging improvements while generating reports (elastic#123802)
  [Uptime] Default alert connectors email settings (elastic#123244)
  Update comparison series styles to match the main series (elastic#123858)
  [RAC][Uptime] remove extra dot from the uptime alert connector message (elastic#124000)
  [Exploratory view] Allow ability add extra actions in lens embeddable (elastic#123713)
  [SecuritySolution][Investigations] Add message about missing index in data view in analyzer (elastic#122859)
  [TSVB] Formatting in the left axis is not respected when I have two separate axis (elastic#123903)
  [Discover] Remove services from component dependencies (elastic#121691)
  Stop IM rule execution if there are no events (elastic#123811)
  [Security Solution][Endpoint] Update Fleet Trusted Apps and Host Isolation Exception cards to use exception list summary API (elastic#123900)
  [Security Solution][Exceptions] Switches modal to flyout component (elastic#123408)
  [Workplace Search] Fix bug where modal visible after deleting a group (elastic#123976)
  [Alerting] Remove state variables from action variable menu (elastic#123702)
  replace deprecated api usage (elastic#123970)
  Fix package policy merge logic for boolean values (elastic#123974)
  [Security Solution][Endpoint][Policy] Remove GET policy list api route (elastic#123873)
  Reenable alert_add test suite (elastic#123862)
  [Fleet] Remove usage of IFieldType in Fleet (elastic#123960)
  [Lists] Add an instance of `ExceptionListClient` with server extension points turned off to context object provided to callbacks (elastic#123885)
  [Maps] Add execution context (elastic#123651)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022
…ation Exception cards to use exception list summary API (elastic#123900)

* don't use deprecated class

ref elastic/pull/123476

* update TA card to use summary api with filter

ref elastic#123476 (review)

* update fleet hie card to use summary api

ref  elastic#123476 (review)

* update param types

review changes

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants