Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution][Investigations] Add message about missing index in data view in analyzer #122859

Merged
merged 3 commits into from
Jan 28, 2022

Conversation

janmonschke
Copy link
Contributor

Summary

When a data view is selected that does not contain the index of the source event for analyzer, we are not able to actually show analyzer. There is no easy automated way to fix this situation for the user so instead we are updating the copy to ask them to check for the correct indices in the selected data view. (original issue: #120885)

Screenshot 2022-01-12 at 18 54 02

@janmonschke janmonschke added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Investigations Security Solution Investigations Team v7.17.0 labels Jan 12, 2022
@janmonschke janmonschke requested a review from a team as a code owner January 12, 2022 17:55
@janmonschke janmonschke self-assigned this Jan 12, 2022
<EuiText size="s">
{i18n.translate('xpack.securitySolution.resolver.noProcessEvents.dataView', {
defaultMessage: `In case you selected a different data view,
make sure your data view contains one of the inidices that are stored in the source event at "{field}".`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of 1, should probably be "all" of the indices (spelling as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 80c18ed

@MadameSheema
Copy link
Member

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +388.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @janmonschke

@janmonschke janmonschke merged commit 9f6c781 into main Jan 28, 2022
@janmonschke janmonschke deleted the security/analyzer-add-data-view-message branch January 28, 2022 09:26
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 28, 2022
… data view in analyzer (elastic#122859)

* chore: add message about missing index in data view

* fix: typo

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 9f6c781)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 28, 2022
… data view in analyzer (elastic#122859)

* chore: add message about missing index in data view

* fix: typo

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 9f6c781)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.0
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 28, 2022
…fix-potential-race-condition-when-screenshotting

* 'main' of github.com:elastic/kibana: (75 commits)
  [Reporting] Logging improvements while generating reports (elastic#123802)
  [Uptime] Default alert connectors email settings (elastic#123244)
  Update comparison series styles to match the main series (elastic#123858)
  [RAC][Uptime] remove extra dot from the uptime alert connector message (elastic#124000)
  [Exploratory view] Allow ability add extra actions in lens embeddable (elastic#123713)
  [SecuritySolution][Investigations] Add message about missing index in data view in analyzer (elastic#122859)
  [TSVB] Formatting in the left axis is not respected when I have two separate axis (elastic#123903)
  [Discover] Remove services from component dependencies (elastic#121691)
  Stop IM rule execution if there are no events (elastic#123811)
  [Security Solution][Endpoint] Update Fleet Trusted Apps and Host Isolation Exception cards to use exception list summary API (elastic#123900)
  [Security Solution][Exceptions] Switches modal to flyout component (elastic#123408)
  [Workplace Search] Fix bug where modal visible after deleting a group (elastic#123976)
  [Alerting] Remove state variables from action variable menu (elastic#123702)
  replace deprecated api usage (elastic#123970)
  Fix package policy merge logic for boolean values (elastic#123974)
  [Security Solution][Endpoint][Policy] Remove GET policy list api route (elastic#123873)
  Reenable alert_add test suite (elastic#123862)
  [Fleet] Remove usage of IFieldType in Fleet (elastic#123960)
  [Lists] Add an instance of `ExceptionListClient` with server extension points turned off to context object provided to callbacks (elastic#123885)
  [Maps] Add execution context (elastic#123651)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 31, 2022
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022
… data view in analyzer (elastic#122859)

* chore: add message about missing index in data view

* fix: typo

Co-authored-by: Kibana Machine <[email protected]>
janmonschke added a commit that referenced this pull request Jan 31, 2022
… data view in analyzer (#122859) (#124002)

* chore: add message about missing index in data view

* fix: typo

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 9f6c781)

Co-authored-by: Jan Monschke <[email protected]>
janmonschke added a commit that referenced this pull request Jan 31, 2022
… data view in analyzer (#122859) (#124001)

* chore: add message about missing index in data view

* fix: typo

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 9f6c781)

Co-authored-by: Jan Monschke <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants