[Uptime] Default alert connectors email settings #123244

shahzad31 · 2022-01-18T16:20:49Z

Summary

Added ability to select email connectors in uptime alert connectors settings.

When email connector is selected. Section to add default email appears. Where user can select, To, Cc, Bcc emails.

Those emails will be used to send alerts via selected email connectors in the uptime page.

Testing

Add an email connector using rule and management page or from the uptime setting page using Add connector button
Configure email connector via https://nodemailer.com/app/ , using this app you can start a dummy email server and specify settings in the email connector like this

    host: 'localhost',
    port: 1025,
    auth: {
        user: 'project.1',
        pass: 'secret.1'
    }

Once email connector is configure you can test it within the connector UI to make sure it works and sends an email, that email will appear in nodemailer app
Select that connector in the uptime setting default alert connectors
Fields to add To, Cc, Bcc should appear in the settings page
If any email connectors is selected To becomes a required field.
All email fields should check for valid emails

Note

Unit testing this component was hard, so i opted for more streamlined e2e tests.

elasticmachine · 2022-01-20T09:08:30Z

Pinging @elastic/uptime (Team:uptime)

x-pack/plugins/uptime/public/components/settings/default_email.tsx

dominiqueclarke · 2022-01-20T17:14:19Z

x-pack/plugins/uptime/public/components/settings/default_email.tsx

+      description={
+        <FormattedMessage
+          id="xpack.uptime.sourceConfiguration.defaultConnectors.description.defaultEmail"
+          defaultMessage="Email settings required for selected email alert connectors."


Might need to adjust this content. Should connectors be plural? Isn't there just one email connector?

x-pack/plugins/uptime/public/components/settings/default_email.tsx

x-pack/plugins/uptime/public/components/settings/translations.ts

x-pack/plugins/uptime/public/pages/settings.tsx

dominiqueclarke

The page is crashing for me when I visit settings. Was on commit 103bf0c

shahzad31 · 2022-01-25T17:54:40Z

@elasticmachine merge upstream

…ail-connector

dominiqueclarke

Styles for the add connector button are a bit off. Default connectors and Add Connector isn't aligned, and the button is missing padding.

dominiqueclarke

I don't see the cc or bcc option for email connector when using the email connector from the alert flyout in Uptime or the Rules and Connectors page

dominiqueclarke

LGTM. Receiving emails for simple alerts and regular alerts as expected.

kibana-ci · 2022-01-27T17:36:49Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`uptime`	690	694	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	674.8KB	675.1KB	+270.0B
`uptime`	704.2KB	709.3KB	+5.1KB
total			+5.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`uptime`	24.9KB	25.1KB	+200.0B

History

💔 Build #20081 failed 5741d39
💔 Build #20033 failed c600b3e
💚 Build #19633 succeeded 0d921f1
💚 Build #19526 succeeded 5151d00
💔 Build #19361 failed 4e77d2e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

paulb-elastic · 2022-01-28T11:14:45Z

The UI looks good to me (the ability to add the email connector as the default, and not being able to Apply changes until an email address is added)

…fix-potential-race-condition-when-screenshotting * 'main' of github.com:elastic/kibana: (75 commits) [Reporting] Logging improvements while generating reports (elastic#123802) [Uptime] Default alert connectors email settings (elastic#123244) Update comparison series styles to match the main series (elastic#123858) [RAC][Uptime] remove extra dot from the uptime alert connector message (elastic#124000) [Exploratory view] Allow ability add extra actions in lens embeddable (elastic#123713) [SecuritySolution][Investigations] Add message about missing index in data view in analyzer (elastic#122859) [TSVB] Formatting in the left axis is not respected when I have two separate axis (elastic#123903) [Discover] Remove services from component dependencies (elastic#121691) Stop IM rule execution if there are no events (elastic#123811) [Security Solution][Endpoint] Update Fleet Trusted Apps and Host Isolation Exception cards to use exception list summary API (elastic#123900) [Security Solution][Exceptions] Switches modal to flyout component (elastic#123408) [Workplace Search] Fix bug where modal visible after deleting a group (elastic#123976) [Alerting] Remove state variables from action variable menu (elastic#123702) replace deprecated api usage (elastic#123970) Fix package policy merge logic for boolean values (elastic#123974) [Security Solution][Endpoint][Policy] Remove GET policy list api route (elastic#123873) Reenable alert_add test suite (elastic#123862) [Fleet] Remove usage of IFieldType in Fleet (elastic#123960) [Lists] Add an instance of `ExceptionListClient` with server extension points turned off to context object provided to callbacks (elastic#123885) [Maps] Add execution context (elastic#123651) ... # Conflicts: # x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts

Co-authored-by: Kibana Machine <[email protected]>

ymao1

Response Ops changes LGTM. Verified that email params still work as expected within the Rules Management UI

lucasfcosta · 2022-02-09T18:05:01Z

I've just tested this, and I've got a few comments and issues to highlight.

Testing the default connector settings

As @shahzad31 mentioned, I have:

Downloaded NodeMailer and started an SMTP server with it
Configured an email connector in Stack Management > Rules and Connectors
Then, on the settings within Uptime, I've configured settings for a default connectors with all fields, trying to check whether the required and non-required fields affected the save button correctly, as shown in the GIF below.

Once I enabled alerts for a monitor I've created and made it fail, I also checked I did receive email alerts on the configured default connector ✅

➡️ Open Issue

As you can see above, the screen actually flashes once I select the email connector, and I can consistently reproduce it by just refreshing the page. I've created an issue for that here: #125124.

Creating a particular monitor alert

Once NodeMailer was setup, as per the test above, I've also tried to create a particular monitor alert, and I correctly got emails for that.

➡️ Open Issue

Typing into the field for the rule name is extremely slow. Whenever I type, I have to wait quite a bit for each character to appear in the input. It seems like there are a bunch of keydown callbacks making this experience slow.

It's currently a very poor experience as you can see below, so I've created an issue for that here: #125123.

Permissions for viewers

It seems like #121098 is also solved.

As you can see below, when logging-in with a read-only user (one with the viewer role, for example), I can't click to create a connector anymore, and thus don't see the aforementioned issue.

shahzad31 changed the title ~~wip~~ [Uptime] Default alert connectors email settings Jan 19, 2022

shahzad31 marked this pull request as ready for review January 20, 2022 09:07

shahzad31 requested a review from a team as a code owner January 20, 2022 09:07

shahzad31 added release_note:enhancement v8.1.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 20, 2022

dominiqueclarke reviewed Jan 20, 2022

View reviewed changes

dominiqueclarke self-requested a review January 20, 2022 17:23

dominiqueclarke requested changes Jan 20, 2022

View reviewed changes

Add email connector

17ef8a7

shahzad31 force-pushed the email-connector branch from 103bf0c to 17ef8a7 Compare January 24, 2022 11:10

shahzad31 added 8 commits January 24, 2022 12:12

PR feedback

1888961

Merge branch 'main' of github.com:elastic/kibana into email-connector

35ae6aa

fix tests

8a81dfe

fix tests

ac8a078

Merge branch 'main' of github.com:elastic/kibana into email-connector

152cbdc

fix types

85e0e3c

fix test

c1d76b4

fix more types

4e77d2e

shahzad31 requested a review from dominiqueclarke January 25, 2022 13:56

shahzad31 added 2 commits January 25, 2022 15:03

update

fc47eb0

fix a bug

2c00e94

kibanamachine and others added 4 commits January 25, 2022 12:54

Merge branch 'main' into email-connector

50afd44

Merge branch 'main' of github.com:elastic/kibana into email-connector

3321381

remove flag

a283b4c

Merge branch 'email-connector' of github.com:shahzad31/kibana into em…

5151d00

…ail-connector

dominiqueclarke reviewed Jan 25, 2022

View reviewed changes

shahzad31 added 2 commits January 25, 2022 22:34

fix cc/bcc

5788927

Merge branch 'main' of github.com:elastic/kibana into email-connector

0d921f1

shahzad31 requested a review from dominiqueclarke January 26, 2022 10:35

shahzad31 added 4 commits January 27, 2022 13:11

Merge branch 'main' of github.com:elastic/kibana into email-connector

c600b3e

Merge branch 'main' of github.com:elastic/kibana into email-connector

eb5a7a4

update type

bc44876

update type

5741d39

dominiqueclarke approved these changes Jan 27, 2022

View reviewed changes

shahzad31 added 2 commits January 27, 2022 17:06

Merge branch 'main' of github.com:elastic/kibana into email-connector

20e4b12

fix flixkering

8d8d823

dominiqueclarke self-requested a review January 27, 2022 16:37

shahzad31 merged commit 957b9dc into elastic:main Jan 28, 2022

shahzad31 deleted the email-connector branch January 28, 2022 11:15

kibanamachine added the backport:skip This commit does not require backporting label Jan 28, 2022

shahzad31 mentioned this pull request Jan 28, 2022

[Uptime] Users without permissions to create actions and connectors can still open the actions and connectors flyout in settings, but can't use it #121098

Closed

awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022

[Uptime] Default alert connectors email settings (elastic#123244)

be339ec

Co-authored-by: Kibana Machine <[email protected]>

ymao1 reviewed Feb 1, 2022

View reviewed changes

lucasfcosta self-assigned this Feb 9, 2022

This was referenced Feb 9, 2022

[Uptime][Alerting] Keypresses are really slow when typing an alert name (blocking keypresses) #125123

Open

[Uptime] Whole screen flashes when selecting a default email connector #125124

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Default alert connectors email settings #123244

[Uptime] Default alert connectors email settings #123244

shahzad31 commented Jan 18, 2022 •

edited

Loading

elasticmachine commented Jan 20, 2022

dominiqueclarke Jan 20, 2022

dominiqueclarke left a comment

shahzad31 commented Jan 25, 2022

dominiqueclarke left a comment

dominiqueclarke left a comment

dominiqueclarke left a comment

kibana-ci commented Jan 27, 2022

paulb-elastic commented Jan 28, 2022

ymao1 left a comment

lucasfcosta commented Feb 9, 2022 •

edited

Loading

[Uptime] Default alert connectors email settings #123244

[Uptime] Default alert connectors email settings #123244

Conversation

shahzad31 commented Jan 18, 2022 • edited Loading

Summary

Testing

Note

elasticmachine commented Jan 20, 2022

dominiqueclarke Jan 20, 2022

Choose a reason for hiding this comment

dominiqueclarke left a comment

Choose a reason for hiding this comment

shahzad31 commented Jan 25, 2022

dominiqueclarke left a comment

Choose a reason for hiding this comment

dominiqueclarke left a comment

Choose a reason for hiding this comment

dominiqueclarke left a comment

Choose a reason for hiding this comment

kibana-ci commented Jan 27, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

paulb-elastic commented Jan 28, 2022

ymao1 left a comment

Choose a reason for hiding this comment

lucasfcosta commented Feb 9, 2022 • edited Loading

Testing the default connector settings

➡️ Open Issue

Creating a particular monitor alert

➡️ Open Issue

Permissions for viewers

shahzad31 commented Jan 18, 2022 •

edited

Loading

lucasfcosta commented Feb 9, 2022 •

edited

Loading